Skip to content

Commit

Permalink
Merge branch 'ARROW-36831' of https://github.com/R-JunmingChen/arrow
Browse files Browse the repository at this point in the history
…into ARROW-36831
  • Loading branch information
R-JunmingChen committed Oct 15, 2023
2 parents 2020d48 + 0b23b35 commit b84486f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions cpp/src/arrow/compute/kernels/aggregate_basic_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,9 @@ struct DictionaryMinMaxImpl : public ScalarAggregator {
ARROW_ASSIGN_OR_RAISE(auto compacted_arr, dict_arr.Compact(ctx->memory_pool()));
const DictionaryArray& compacted_dict_arr =
checked_cast<const DictionaryArray&>(*compacted_arr);
this->has_nulls |= compacted_dict_arr.null_count() > 0;
this->count += compacted_dict_arr.length() - compacted_dict_arr.null_count();

const std::shared_ptr<Array>& dict = compacted_dict_arr.dictionary();
if (dict->length() == 0) {
return Status::OK();
Expand Down

0 comments on commit b84486f

Please sign in to comment.