Skip to content

Commit

Permalink
apacheGH-38900:[JS] Fix spelling (apache#38901)
Browse files Browse the repository at this point in the history
#
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on
how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)


If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.

Then could you also rename the pull request title in the following
format?

    GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

    MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

    PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

-->

### Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

### What changes are included in this PR?

Spelling fixes to js/
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

### Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

### Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please uncomment the
line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->

<!--
Please uncomment the line below (and provide explanation) if the changes
fix either (a) a security vulnerability, (b) a bug that caused incorrect
or invalid data to be produced, or (c) a bug that causes a crash (even
when the API contract is upheld). We use this to highlight fixes to
issues that may affect users without their knowledge. For this reason,
fixing bugs that cause errors don't count, since those are usually
obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
* ~Closes~: apache#38900
* Closes: apache#38900

---------

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
  • Loading branch information
jsoref authored Nov 27, 2023
1 parent bf79d6e commit 63353ba
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions js/src/enum.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// v4 doesn't seem to be able to tree-shake the rest of those exports.
//
// We will have to keep these enums in sync when we re-generate the flatbuffers
// code from the shchemas. See js/DEVELOP.md for info on how to run flatbuffers
// code from the schemas. See js/DEVELOP.md for info on how to run flatbuffers
// code generation.
//
////
Expand Down Expand Up @@ -174,7 +174,7 @@ export enum Type {
FixedSizeBinary = 15, /** Fixed-size binary. Each value occupies the same number of bytes */
FixedSizeList = 16, /** Fixed-size list. Each value occupies the same number of bytes */
Map = 17, /** Map of named logical types */
Duration = 18, /** Measure of elapsed time in either seconds, miliseconds, microseconds or nanoseconds. */
Duration = 18, /** Measure of elapsed time in either seconds, milliseconds, microseconds or nanoseconds. */

Dictionary = -1, /** Dictionary aka Category type */
Int8 = -2,
Expand Down Expand Up @@ -215,7 +215,7 @@ export enum BufferType {
OFFSET = 0,

/**
* actual data, either wixed width primitive types in slots or variable width delimited by an OFFSET vector
* actual data, either fixed width primitive types in slots or variable width delimited by an OFFSET vector
*/
DATA = 1,

Expand Down
2 changes: 1 addition & 1 deletion js/src/fb/timestamp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ import { TimeUnit } from './time-unit.js';
* no indication of how to map this information to a physical point in time.
* Naive date-times must be handled with care because of this missing
* information, and also because daylight saving time (DST) may make
* some values ambiguous or non-existent. A naive date-time may be
* some values ambiguous or nonexistent. A naive date-time may be
* stored as a struct with Date and Time fields. However, it may also be
* encoded into a Timestamp column with an empty timezone. The timestamp
* values should be computed "as if" the timezone of the date-time values
Expand Down
2 changes: 1 addition & 1 deletion js/src/ipc/reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export class RecordBatchReader<T extends TypeMap = any> extends ReadableInterop<

//
// Since TS is a structural type system, we define the following subclass stubs
// so that concrete types exist to associate with with the interfaces below.
// so that concrete types exist to associate with the interfaces below.
//
// The implementation for each RecordBatchReader is hidden away in the set of
// `RecordBatchReaderImpl` classes in the second half of this file. This allows
Expand Down
4 changes: 2 additions & 2 deletions js/src/vector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ export class Vector<T extends DataType = any> {
* values.
*
* Memoization is very useful when decoding a value is expensive such as
* Uft8. The memoization creates a cache of the size of the Vector and
* therfore increases memory usage.
* Utf8. The memoization creates a cache of the size of the Vector and
* therefore increases memory usage.
*
* @returns A new vector that memoizes calls to {@link get}.
*/
Expand Down
2 changes: 1 addition & 1 deletion js/src/visitor/builderctor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class GetBuilderCtor extends Visitor {
public visitDurationSecond() { return DurationSecondBuilder; }
public visitDurationMillisecond() { return DurationMillisecondBuilder; }
public visitDurationMicrosecond() { return DurationMicrosecondBuilder; }
public visistDurationNanosecond() { return DurationNanosecondBuilder; }
public visitDurationNanosecond() { return DurationNanosecondBuilder; }
public visitFixedSizeList() { return FixedSizeListBuilder; }
public visitMap() { return MapBuilder; }
}
Expand Down
2 changes: 1 addition & 1 deletion js/src/visitor/indexof.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ function indexOfValue<T extends DataType>(data: Data<T>, searchElement?: T['TVal
function indexOfUnion<T extends DataType>(data: Data<T>, searchElement?: T['TValue'] | null, fromIndex?: number): number {
// Unions are special -- they do have a nullBitmap, but so can their children.
// If the searchElement is null, we don't know whether it came from the Union's
// bitmap or one of its childrens'. So we don't interrogate the Union's bitmap,
// bitmap or one of its children's. So we don't interrogate the Union's bitmap,
// since that will report the wrong index if a child has a null before the Union.
const get = getVisitor.getVisitFn(data);
const compare = createElementComparator(searchElement);
Expand Down
4 changes: 2 additions & 2 deletions js/src/visitor/jsonvectorassembler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ export class JSONVectorAssembler extends Visitor {

/** @nocollapse */
public static assemble<T extends RecordBatch>(...batches: T[]) {
const assemlber = new JSONVectorAssembler();
const assembler = new JSONVectorAssembler();
return batches.map(({ schema, data }) => {
return assemlber.visitMany(schema.fields, data.children);
return assembler.visitMany(schema.fields, data.children);
});
}

Expand Down

0 comments on commit 63353ba

Please sign in to comment.