Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial PoC for style scope inherit #2727

Closed
wants to merge 1 commit into from
Closed

initial PoC for style scope inherit #2727

wants to merge 1 commit into from

Conversation

heinthanth
Copy link

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Add a way to declare component$ which shares parent component styling scope.

Use cases and why

Will complete this feature request ( #2726 )

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Jan 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zanettin
Copy link
Contributor

Hi @heinthanth
Thanks for creating this draft 🙏 do this changes go in the same direction as Manu's PR? #2730

@heinthanth
Copy link
Author

@zanettin Yes, that was the same direction ( but different approach - mentioned in issue comments ). Feel free to close this.

@zanettin
Copy link
Contributor

@heinthanth don't have the power to close anything and leave it up to the core team to decide 😎 just wanted to check if they are related. thanks again

@shairez shairez closed this Feb 7, 2023
@shairez
Copy link
Contributor

shairez commented Feb 7, 2023

thanks for the contribution @heinthanth !
(and for the triage @zanettin )

@heinthanth heinthanth deleted the feat-style-scope-inherit branch February 7, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants