Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 0.0.59 #971

Conversation

StanGirard
Copy link
Collaborator

@StanGirard StanGirard commented Aug 17, 2023

🤖 I have created a release beep boop

0.0.59 (2023-08-20)

Features

  • aws: all in microservices (b3a6231)
  • chat-service: added task definition (d001ec7)
  • docker: improved size image (#978) (aa623c4)
  • docker: pushing image to github registry (ad3dca3)
  • gcr: removed sha and put latest (2b85a94)
  • health: added endpoint for services (#989) (ae7852e)
  • microservices: split into 4 quivr to better handle long services (#972) (7281fd9)
  • preview: added crawl service to ci (b7f9876)
  • preview: added preview (#974) (9eb25a4)
  • preview: added service upload (#979) (ce6b45e)
  • refacto: changed a bit of things to make better dx (#984) (d0370ab)
  • Unplug: chatting without brain streaming (#970) (600ff1e)

Bug Fixes


This PR was generated with Release Please. See documentation.

@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from dcec9c5 to 0abfd04 Compare August 17, 2023 17:11
@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 9:25pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 9:25pm

@StanGirard StanGirard temporarily deployed to preview August 17, 2023 17:11 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from 0abfd04 to cd9fd1f Compare August 18, 2023 08:19
@StanGirard StanGirard temporarily deployed to preview August 18, 2023 08:19 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from cd9fd1f to cc1c121 Compare August 18, 2023 08:33
@StanGirard StanGirard temporarily deployed to preview August 18, 2023 08:33 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from cc1c121 to d2d6fb3 Compare August 18, 2023 08:49
@StanGirard StanGirard temporarily deployed to preview August 18, 2023 08:49 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from d2d6fb3 to 1ed6ca6 Compare August 18, 2023 10:12
@StanGirard StanGirard temporarily deployed to preview August 18, 2023 10:13 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from 1ed6ca6 to 5f8b28a Compare August 18, 2023 10:26
@StanGirard StanGirard temporarily deployed to preview August 18, 2023 10:26 — with GitHub Actions Inactive
@StanGirard StanGirard temporarily deployed to preview August 18, 2023 10:26 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Risk Level 2 - /home/runner/work/quivr/quivr/backend/core/main.py

The code seems to be well-structured and follows the SOLID principles. However, there are a few areas that could be improved for better readability and maintainability:

  1. Environment Variables: The SENTRY_DSN environment variable is being accessed directly using os.getenv(). It would be better to use a configuration file or class to manage all environment variables. This would make it easier to handle defaults and required variables.

  2. Error Handling: The validation_exception_handler function could be simplified for better readability. Instead of manually replacing newline and space characters in the exception string, consider using the str.strip() method.

Here's an example of how you might implement these changes:

# Config class to handle environment variables
class Config:
    SENTRY_DSN: str = os.getenv(\"SENTRY_DSN\")

# Simplified error handling
@app.exception_handler(RequestValidationError)
async def validation_exception_handler(request: Request, exc: RequestValidationError):
    exc_str = str(exc).strip()
    logger.error(request, exc_str)
    content = {
        \"status_code\": status.HTTP_422_UNPROCESSABLE_ENTITY,
        \"message\": exc_str,
        \"data\": None,
    }
    return JSONResponse(content=content, status_code=status.HTTP_422_UNPROCESSABLE_ENTITY)

Remember to replace all instances of os.getenv(\"SENTRY_DSN\") with Config.SENTRY_DSN.


🌍💼🔧


Powered by Code Review GPT

@StanGirard StanGirard temporarily deployed to preview August 18, 2023 16:29 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from a644571 to d63b0a2 Compare August 18, 2023 16:36
@StanGirard StanGirard temporarily deployed to preview August 18, 2023 16:36 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from d63b0a2 to 3783553 Compare August 19, 2023 10:31
@StanGirard StanGirard temporarily deployed to preview August 19, 2023 10:32 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from 3783553 to 24cf1b2 Compare August 19, 2023 11:33
@StanGirard StanGirard temporarily deployed to preview August 19, 2023 11:33 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from 24cf1b2 to 5653c33 Compare August 20, 2023 09:57
@StanGirard StanGirard temporarily deployed to preview August 20, 2023 09:57 — with GitHub Actions Inactive
@StanGirard StanGirard force-pushed the release-please--branches--main--components--release-please-action branch from 5653c33 to ae27708 Compare August 20, 2023 21:21
@StanGirard StanGirard temporarily deployed to preview August 20, 2023 21:21 — with GitHub Actions Inactive
@gozineb gozineb merged commit 5b79025 into main Aug 21, 2023
@StanGirard
Copy link
Collaborator Author

🤖 Release is at https://github.com/StanGirard/quivr/releases/tag/v0.0.59 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants