chore(embeddings): added tests for embeddings #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:M
dosubot
bot
added
the
area: backend
StanGirard
changed the title
AmineDiro
reviewed
Sep 10, 2024
| mock_settings.azure_openai_embeddings_url = None | ||
|
|
||
| # Create a mock instance for OpenAIEmbeddings | ||
| mock_openai_instance = MagicMock() |
There was a problem hiding this comment.
Why the need for MagicMock here 🤔 . As I understand we are patching the environement to check that we get the correct embedding instance ? Is the openaiembedding instance different from the other cases ?
There was a problem hiding this comment.
Yes we read the env key from the env. the others are in the settings
StanGirard
added a commit
that referenced
this pull request
Sep 12, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.311 (2024-09-12) ## What's Changed * chore(embeddings): added tests for embeddings by @StanGirard in #3183 * feat(uptime): check if connection to db works by @StanGirard in #3199 **Full Changelog**: v0.0.310...v0.0.311 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):