Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

difference assistant #2701

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

difference assistant #2701

wants to merge 2 commits into from

Conversation

chloedia
Copy link
Collaborator

DO NOT MERGE

Description

Add of a specific assistant for difference review on 2 files

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@vercel Vercel
Copy link

vercel bot commented Jun 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:23pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. area: backend Related to backend functionality or under the /backend directory labels Jun 21, 2024
@chloedia chloedia marked this pull request as draft June 21, 2024 08:45
AmineDiro
AmineDiro requested changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@AmineDiro AmineDiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work !

Some changes required in the celery_tasks and small input on the diff assistant

backend/modules/assistant/ito/difference/difference_agent.py Outdated Show resolved Hide resolved
backend/modules/assistant/ito/difference/difference_agent.py Outdated Show resolved Hide resolved
backend/modules/assistant/ito/difference/difference_agent.py Outdated Show resolved Hide resolved
backend/modules/assistant/ito/difference/difference_agent.py Outdated Show resolved Hide resolved
backend/modules/assistant/ito/difference/query_engine.py Outdated Show resolved Hide resolved
backend/modules/assistant/ito/difference/difference_agent.py
self.diff_query_engine = diff_query_engine

self.questions = None
self.generated_df = pd.DataFrame()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to initiate an empty dataframe here just to override it or we can return an empty df ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can override it, and if there was an error we can access an empty df (if empty .. )

backend/modules/assistant/ito/difference/difference_agent.py Outdated Show resolved Hide resolved
backend/modules/assistant/ito/difference/difference_agent.py Outdated Show resolved Hide resolved
backend/modules/assistant/ito/difference_assistant.py
return markdown_content


def difference_inputs():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small naming change difference_outputs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Called like that in list assistant / assistant_routes

backend/modules/assistant/ito/difference_assistant.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineDiro AmineDiro AmineDiro requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@AmineDiro AmineDiro

@chloedia chloedia

Labels
area: backend Related to backend functionality or under the /backend directory size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chloedia @AmineDiro