-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
difference assistant #2701
base: main
Are you sure you want to change the base?
difference assistant #2701
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work !
Some changes required in the celery_tasks and small input on the diff assistant
self.diff_query_engine = diff_query_engine | ||
|
||
self.questions = None | ||
self.generated_df = pd.DataFrame() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to initiate an empty dataframe here just to override it or we can return an empty df ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we can override it, and if there was an error we can access an empty df (if empty .. )
return markdown_content | ||
|
||
|
||
def difference_inputs(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small naming change difference_outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Called like that in list assistant / assistant_routes
|
DO NOT MERGE
Description
Add of a specific assistant for difference review on 2 files
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):