fix: Fix error message in SummaryAssistant class #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
area: backend
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 0310e8e
- Looked at
14lines of code in1files - Took 37 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. /backend/modules/assistant/ito/summary.py:53:
- Assessed confidence :
100% - Grade:
0% - Comment:
The error message 'No files key were given in the input' is not clear. Consider changing it to 'No files were provided in the input'. - Reasoning:
The error message 'No files key were given in the input' is not clear. It would be better to say 'No files were provided in the input'.
Workflow ID: wflow_c3hrJOFpELkO7jFu
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
⌛ You have 5 hours remaining in your free trial. Upgrade at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at help@ellipsis.dev
StanGirard
added a commit
that referenced
this pull request
Apr 19, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.232 (2024-04-19) ## What's Changed * Update CPU and memory settings in task definition files by @StanGirard in #2450 * fix: Fix error message in SummaryAssistant class by @StanGirard in #2453 **Full Changelog**: v0.0.231...v0.0.232 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):
Summary:
This PR refines an error message in the
check_inputfunction of theSummaryAssistantclass in/backend/modules/assistant/ito/summary.pyto more accurately reflect the error condition.Key points:
check_inputfunction ofSummaryAssistantclass/backend/modules/assistant/ito/summary.pyGenerated with ❤️ by ellipsis.dev