feat(assistants): Add PDF generation functionality and nice emails #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
area: backend
|
Generated with ❤️ by ellipsis.dev |
|
Sorry, Ellipsis encountered a problem while reviewing this PR at commit cb0051f. Our team has been alerted and is investigating. (wflow_qCdvuPoJaIKZgSLT) 🤖 |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Performed an incremental review on 8921eb9
- Looked at
272lines of code in7files - Took 5 minutes and 33 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
6additional comments because they didn't meet confidence threshold of50%.
1. backend/modules/assistant/ito/utils/Pipfile:7:
- Assessed confidence :
100% - Grade:
0% - Comment:
The 'unidecode' package is added twice in the project. Once in the main Pipfile and again in the Pipfile inside the 'ito/utils' directory. This could lead to version conflicts and is generally not a good practice. The package should be included in the main Pipfile and removed from the 'ito/utils' Pipfile. - Reasoning:
The 'unidecode' package is added twice in the project. Once in the main Pipfile and again in the Pipfile inside the 'ito/utils' directory. This could lead to version conflicts and is generally not a good practice. The package should be included in the main Pipfile and removed from the 'ito/utils' Pipfile.
2. backend/modules/assistant/ito/utils/Pipfile:1:
- Assessed confidence :
100% - Grade:
0% - Comment:
This directory has its own Pipfile and Pipfile.lock, which is unusual. Typically, a Python project has a single set of these files at the root level. Having multiple sets of these files can lead to dependency conflicts and make the project harder to manage. It would be better to consolidate these files at the project root level. - Reasoning:
The 'ito/utils' directory has its own Pipfile and Pipfile.lock, which is unusual. Typically, a Python project has a single set of these files at the root level. Having multiple sets of these files can lead to dependency conflicts and make the project harder to manage. It would be better to consolidate these files at the project root level.
3. backend/modules/assistant/ito/utils/Pipfile.lock:1:
- Assessed confidence :
100% - Grade:
40% - Comment:
This directory has its own Pipfile.lock, which is unusual. Typically, a Python project has a single Pipfile.lock at the root level. Having multiple Pipfile.lock files can lead to dependency conflicts and make the project harder to manage. It would be better to consolidate this file at the project root level. - Reasoning:
The 'ito/utils' directory has its own Pipfile.lock, which is unusual. Typically, a Python project has a single Pipfile.lock at the root level. Having multiple Pipfile.lock files can lead to dependency conflicts and make the project harder to manage. It would be better to consolidate this file at the project root level.
4. backend/modules/assistant/ito/utils/pdf_generator.py:38:
- Assessed confidence :
100% - Grade:
0% - Comment:
The 'header' function is missing a docstring. According to PEP 257, all public functions should have a docstring. This docstring should provide a brief overview of the function's purpose, its inputs, outputs, and any important details the user of the function should know. - Reasoning:
The 'pdf_generator.py' file is missing a docstring at the function level for 'header'. This is a violation of PEP 257, which recommends that all public functions should have a docstring. This docstring should provide a brief overview of the function's purpose, its inputs, outputs, and any important details the user of the function should know.
5. backend/modules/assistant/ito/utils/pdf_generator.py:51:
- Assessed confidence :
100% - Grade:
0% - Comment:
The 'footer' function is missing a docstring. According to PEP 257, all public functions should have a docstring. This docstring should provide a brief overview of the function's purpose, its inputs, outputs, and any important details the user of the function should know. - Reasoning:
The 'pdf_generator.py' file is missing a docstring at the function level for 'footer'. This is a violation of PEP 257, which recommends that all public functions should have a docstring. This docstring should provide a brief overview of the function's purpose, its inputs, outputs, and any important details the user of the function should know.
6. backend/modules/assistant/ito/utils/pdf_generator.py:62:
- Assessed confidence :
100% - Grade:
0% - Comment:
The 'chapter_body' function is missing a docstring. According to PEP 257, all public functions should have a docstring. This docstring should provide a brief overview of the function's purpose, its inputs, outputs, and any important details the user of the function should know. - Reasoning:
The 'pdf_generator.py' file is missing a docstring at the function level for 'chapter_body'. This is a violation of PEP 257, which recommends that all public functions should have a docstring. This docstring should provide a brief overview of the function's purpose, its inputs, outputs, and any important details the user of the function should know.
Workflow ID: wflow_Zt5oGm4vyzUS0TKG
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
⌛ You have 2 days remaining in your free trial. Upgrade at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at help@ellipsis.dev
| [dev-packages] | ||
|
|
||
| [requires] | ||
| python_version = "3.12" |
There was a problem hiding this comment.
The Python version specified here is '3.12', which is not a released version of Python. This could cause issues when trying to install the dependencies in this environment. The Python version should be changed to a valid released version.
There was a problem hiding this comment.
👍 Looks good to me!
- Performed an incremental review on ccecff7
- Looked at
117lines of code in4files - Took 2 minutes and 14 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. docker-compose.dev.yml:46:
- Assessed confidence :
80% - Grade:
0% - Comment:
The build context and Dockerfile have been removed from the worker, beat, and flower services. Please ensure that these services do not require a specific build context or Dockerfile. - Reasoning:
The docker-compose.dev.yml file has been modified. The build context and Dockerfile have been removed from the worker, beat, and flower services. This could potentially cause issues if these services require a specific build context or Dockerfile. I need to check if these changes are appropriate and won't cause any issues.
Workflow ID: wflow_pbxOzJi21xRS8P1t
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
⌛ You have 2 days remaining in your free trial. Upgrade at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at help@ellipsis.dev
StanGirard
added a commit
that referenced
this pull request
Apr 19, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.231 (2024-04-19) ## What's Changed * feat(assistants): Add user usage update and pricing calculation to ITO assistant by @StanGirard in #2433 * feat(assistant): improve prompt summary by @StanGirard in #2435 * feat(assistants): Add PDF generation functionality and nice emails by @StanGirard in #2436 * feat(analytics): rely on sql rather that python loop for brains by @StanGirard in #2437 * fix(assistant): summary now can output 2000 tokens by @StanGirard in #2440 * feat(assistant): check if key of file is same as filename uploaded by @StanGirard in #2439 * feat: Update Docker build commands and dependencies by @StanGirard in #2441 * feat(rag): Refactor DEFAULT_DOCUMENT_PROMPT in quivr_rag.py by @StanGirard in #2442 * Enable Porter Application quivr-back by @porter-deployment-app in #2443 * Enable Porter Application quivr-demo-front by @porter-deployment-app in #2444 * fix(assistants): brain id is null by @StanGirard in #2445 * feat(summary): improve prompt to get more insights by @StanGirard in #2446 * feat(aws): Update CPU and memory configurations for task definitions by @StanGirard in #2447 * feat(frontend): Quivr Assistants by @Zewed in #2448 **Full Changelog**: v0.0.230...v0.0.231 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- ELLIPSIS_HIDDEN --> ---- | 🚀 This description was created by [Ellipsis](https://www.ellipsis.dev) for commit a16fa4d | |--------| ### Summary: This PR releases version 0.0.231, introducing several feature enhancements and bug fixes across the assistant, analytics, Docker, and frontend modules. **Key points**: - Release version 0.0.231 with feature enhancements and bug fixes across multiple modules - User usage update and pricing calculation added to ITO assistant - Improved prompt summary in assistant module - PDF generation functionality and email enhancements added - Analytics optimized by relying on SQL instead of Python loop - Token output limit fixed in assistant summary - Docker build commands and dependencies updated - DEFAULT_DOCUMENT_PROMPT in quivr_rag.py refactored - Porter Applications for quivr-back and quivr-demo-front enabled - Null brain id issue fixed in assistants module - Prompt improved for better insights in summary module - CPU and memory configurations for AWS task definitions updated - Quivr Assistants added in frontend ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds PDF generation functionality and improves the formatting of emails. It includes a new module for generating PDFs using the fpdf2 library and updates the email templates to use markdown formatting for better readability.
Summary:
This PR introduces PDF generation functionality, improves email formatting, sanitizes filenames, updates various files and dependencies, and updates
docker-compose.dev.yml.Key points:
fpdf2libraryunidecodelibrarybackend/modules/assistant/ito/ito.pyto generate PDFs and sanitize filenamespdf_generator.pyinbackend/modules/assistant/ito/utils/for PDF generationPipfileandPipfile.lockinbackend/modules/assistant/ito/utils/to includeunidecoderequirements.txtwith new dependenciesdocker-compose.dev.ymlGenerated with ❤️ by ellipsis.dev