feat(chatInput): use tiptap editor #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
area: frontend
mamadoudicko
force-pushed
the
feat/use-tip-tap-editor
branch
from
31c078d to
cbf1a35
Compare
mamadoudicko
force-pushed
the
feat/use-tip-tap-editor
branch
from
cbf1a35 to
90cec94
Compare
mamadoudicko
force-pushed
the
feat/use-tip-tap-editor
branch
2 times, most recently
from
2c59a7e to
a9f7d39
Compare
gozineb
reviewed
Nov 29, 2023
| vi.mock( | ||
| "../components/ActionsBar/components/ChatInput/components/ChatEditor/ChatEditor", | ||
| () => ({ | ||
| ChatEditor: () => <div data-testid="chat-input" />, |
There was a problem hiding this comment.
Can we try using 'userEvent' and actually texting the behaviour of the component for next time:
AAU, I am able to click on @ and the menu appears, I can manipulate the menu with the keyboard and click, after that it appears on the screen and I can write a message
Wdyt ?
mamadoudicko
force-pushed
the
feat/use-tip-tap-editor
branch
from
a9f7d39 to
318c853
Compare
StanGirard
approved these changes
Nov 29, 2023
StanGirard
added a commit
that referenced
this pull request
Nov 29, 2023
🤖 I have created a release *beep* *boop* --- ## 0.0.124 (2023-11-29) ## What's Changed * feat(chatInput): use tiptap editor by @mamadoudicko in #1752 * docs: update guidelines.md by @eltociear in #1755 * Feat/local llm bug fix by @StanGirard in #1758 **Full Changelog**: v0.0.123...v0.0.124 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst
added a commit
to coolCatalyst/quivr
that referenced
this pull request
Jun 1, 2024
🤖 I have created a release *beep* *boop* --- ## 0.0.124 (2023-11-29) ## What's Changed * feat(chatInput): use tiptap editor by @mamadoudicko in QuivrHQ/quivr#1752 * docs: update guidelines.md by @eltociear in QuivrHQ/quivr#1755 * Feat/local llm bug fix by @StanGirard in QuivrHQ/quivr#1758 **Full Changelog**: QuivrHQ/quivr@v0.0.123...v0.0.124 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Follow-up:
Demo:
Screen.Recording.2023-11-29.at.16.50.59.mp4