Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improved Text Visibility in Dark Mode in OnboardingQuestion Component #1456

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Dev-Dz27
Copy link
Contributor

Description

In this pull request, I addressed an issue with text visibility in dark mode within the OnboardingQuestion component. The problem was resolved by modifying the class name.

Changes Made

I changed the class name in the OnboardingQuestion component from:

cursor-pointer shadow-md dark:shadow-primary/25 hover:shadow-xl transition-shadow bg-onboarding-yellow-bg px-3 py-1 rounded-xl border-black/10 dark:border-white/25

to:

cursor-pointer shadow-md dark:shadow-primary/25 hover:shadow-xl transition-shadow bg-onboarding-yellow-bg px-3 py-1 rounded-xl border-black/10 dark:border-white/25 dark:text-black

Motivation

The motivation for this change is to improve the visibility of text in dark mode, making the user experience better and ensuring that the UI remains consistent.

Checklist before requesting a review

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have added comments to explain any hard-to-understand areas.
  • I have not added tests in this specific pull request, as this change primarily deals with CSS class modification.
  • New and existing unit tests pass locally with my changes.
  • No dependent changes are required for this fix.

Screenshots (if appropriate)

Problem Before Fix

Problem Before Fix

Fix Applied

Fix Applied

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 7:59am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 7:59am

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 22, 2023
@vercel
Copy link

vercel bot commented Oct 22, 2023

@Dev-Dz27 is attempting to deploy a commit to the Quivr-app Team on Vercel.

A member of the Team first needs to authorize it.

@StanGirard StanGirard merged commit bb1e2e3 into QuivrHQ:main Oct 23, 2023
@StanGirard
Copy link
Collaborator

Thanks a lot :)

mamadoudicko pushed a commit that referenced this pull request Oct 23, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.95 (2023-10-23)

## What's Changed
* feat: homepage first section by @matthieujacq in
#1439
* fix: show a flat gradient in the UseCase section by @matthieujacq in
#1440
* style: update testimonials display by @mamadoudicko in
#1441
* feat: fetch homepage data from CMS by @mamadoudicko in
#1452
* feat: contact sales page (front layout) by @matthieujacq in
#1451
* Fix: Improved Text Visibility in Dark Mode in OnboardingQuestion
Component by @Dev-Dz27 in #1456
* feat(cms): added single video demo by @StanGirard in
#1459
* feat: fetch demo video from CMS by @mamadoudicko in
#1461
* feat: Contact form component by @matthieujacq in
#1453

## New Contributors
* @Dev-Dz27 made their first contribution in
#1456

**Full Changelog**:
v0.0.94...v0.0.95

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.95 (2023-10-23)

## What's Changed
* feat: homepage first section by @matthieujacq in
QuivrHQ/quivr#1439
* fix: show a flat gradient in the UseCase section by @matthieujacq in
QuivrHQ/quivr#1440
* style: update testimonials display by @mamadoudicko in
QuivrHQ/quivr#1441
* feat: fetch homepage data from CMS by @mamadoudicko in
QuivrHQ/quivr#1452
* feat: contact sales page (front layout) by @matthieujacq in
QuivrHQ/quivr#1451
* Fix: Improved Text Visibility in Dark Mode in OnboardingQuestion
Component by @Dev-Dz27 in QuivrHQ/quivr#1456
* feat(cms): added single video demo by @StanGirard in
QuivrHQ/quivr#1459
* feat: fetch demo video from CMS by @mamadoudicko in
QuivrHQ/quivr#1461
* feat: Contact form component by @matthieujacq in
QuivrHQ/quivr#1453

## New Contributors
* @Dev-Dz27 made their first contribution in
QuivrHQ/quivr#1456

**Full Changelog**:
QuivrHQ/quivr@v0.0.94...v0.0.95

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants