feat: add multiple upload and crawl in parallel

[mamadoudicko]

Screen.Recording.2023-09-06.at.14.13.13.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 6, 2023 0:33am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 6, 2023 0:33am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/KnowledgeToFeed/KnowledgeToFeed.tsx

The code is well written and follows the SOLID principles. However, there is a potential risk of the contents state not being properly managed. If there are multiple instances of KnowledgeToFeed component, they will all share the same state which might lead to unexpected behavior. Consider encapsulating the state inside the component or use a more sophisticated state management solution if necessary.

---

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/KnowledgeToFeed/components/FileUploader/hooks/useFileUploader.ts

The code seems to be well written and follows good practices. However, there is a potential issue with the useFileUploader function. It seems to be using a redirectToLogin function when the session is null. This could potentially lead to unexpected behavior if the session becomes null during the execution of the function. It would be better to handle this case more gracefully, perhaps by returning an error or throwing an exception.

if (session === null) {
  redirectToLogin();
}

Suggestion:

if (session === null) {
  throw new Error('Session is null');
}

---

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/hooks/useKnowledgeUploader.ts

The useKnowledgeUploader function seems to be handling errors correctly, but it could be improved by providing more specific error messages. Currently, it is using JSON.stringify(error) to display the error message, which might not be very user-friendly. It would be better to provide a more specific error message based on the type of error.

publish({
  variant: \"danger\",
  text: t(\"crawlFailed\", {
    message: JSON.stringify(error),
    ns: \"upload\",
  }),
});

Suggestion:

publish({
  variant: \"danger\",
  text: t(\"crawlFailed\", {
    message: error instanceof Error ? error.message : 'Unknown error',
    ns: \"upload\",
  }),
});

---

🔄🔒🚨

---

Powered by Code Review GPT

[StanGirard]

Love it 🥰

[gozineb]

why first rejection ?