Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brain as API] 3. AQuivr, i can save user's secrets related to an api brain #1551

Closed
mamadoudicko opened this issue Nov 1, 2023 · 2 comments
Closed

[Brain as API] 3. AQuivr, i can save user's secrets related to an api brain #1551

mamadoudicko opened this issue Nov 1, 2023 · 2 comments
Assignees
@gozineb
Labels
area: backend Related to backend functionality or under the /backend directory Stale user story Subdivision of an epic

Comments

@mamadoudicko
Copy link
Contributor

mamadoudicko commented Nov 1, 2023 •
edited by gozineb
Loading

Link to the Epic

#1380

Explain the Functionality

  • When an api brain is created and contains some secrets, all subscribers should fill with their own secrets. We need to save these secrets in a vault storage

Tech To-dos

  • Add an utils to build secret_id pattern which is user_id-brain_id-secret_name
  • Add supabase rpc function insert_secret and remove_secret
  • Add related repositories

Tests

  • Test unitaire sur l'util build secret_id

Validation Checks

  • Go to Supabase
  • Check that insert_secret and remove_secret SQL functions are there
  • Check that corresponding calling functions are in code base
@mamadoudicko mamadoudicko added the user story Subdivision of an epic label Nov 1, 2023
@mamadoudicko mamadoudicko self-assigned this Nov 1, 2023
@mamadoudicko mamadoudicko moved this to Sprint Backlog in Quivr's Roadmap Nov 1, 2023
@mamadoudicko mamadoudicko changed the title 2. AAD, i have a table for api_brain_config_secrets to stock api_brain secrets [Brain as API] 2. AAD, i have a table for api_brain_config_secrets to stock api_brain secrets Nov 1, 2023
@mamadoudicko mamadoudicko changed the title [Brain as API] 2. AAD, i have a table for api_brain_config_secrets to stock api_brain secrets [Brain as API] 2. AQuivr, i can save user's secrets related to an api brain Nov 1, 2023
@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Nov 1, 2023
@mamadoudicko mamadoudicko changed the title [Brain as API] 2. AQuivr, i can save user's secrets related to an api brain [Brain as API] 3. AQuivr, i can save user's secrets related to an api brain Nov 1, 2023
@mamadoudicko
Copy link
Contributor Author

For inspiration: https://makerkit.dev/blog/tutorials/supabase-vault

@mamadoudicko mamadoudicko assigned gozineb and unassigned mamadoudicko Nov 7, 2023
@mamadoudicko mamadoudicko moved this from Sprint Backlog to In Progress in Quivr's Roadmap Nov 7, 2023
@gozineb gozineb mentioned this issue Nov 7, 2023
Merged
6 tasks
gozineb added a commit that referenced this issue Nov 7, 2023
@gozineb
feat: supabase vault (#1605)
ed5de8b 
# Description

#1551

## Checklist before requesting a review

Please delete options that are not relevant.

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented hard-to-understand areas
- [ ] I have ideally added tests that prove my fix is effective or that
my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged

## Screenshots (if appropriate):
@gozineb gozineb moved this from In Progress to To Be Validated in Quivr's Roadmap Nov 7, 2023
@Chloeroumengas Chloeroumengas moved this from To Be Validated to Done in Quivr's Roadmap Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Thanks for your contributions, we'll be closing this issue as it has gone stale. Feel free to reopen if you'd like to continue the discussion.

@github-actions github-actions bot added the Stale label Dec 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
coolCatalyst added a commit to coolCatalyst/quivr that referenced this issue Jun 1, 2024
@coolCatalyst
feat: supabase vault (#1605)
7b51cc4 
# Description

QuivrHQ/quivr#1551

## Checklist before requesting a review

Please delete options that are not relevant.

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented hard-to-understand areas
- [ ] I have ideally added tests that prove my fix is effective or that
my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged

## Screenshots (if appropriate):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gozineb gozineb

Labels
area: backend Related to backend functionality or under the /backend directory Stale user story Subdivision of an epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mamadoudicko @gozineb