Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bamboo verbose on haproxy reload errors #45

Merged
merged 2 commits into from
Oct 20, 2014

Commits on Oct 19, 2014

  1. Combine sequential update events

    We move the haproxy update and reload logic into a go routine which listens for
    update requests on updateChan. If an update is already queued, the channel is
    drained and another update request is sent. This way there can only be one
    pending update queued. At the same time, no update can be missed.
    
    By moving the real haproxy reload work into a go routine, the actual HTTP
    handler remains fast and slim. Before this patch in real world environements it
    took over 2 seconds to return. Marathon sometimes sends a lot of events
    sequentially, leading to HTTP POST timeouts on Marathon's side if the HTTP
    handler takes so long. This patch will fix this and at the same time reduce the
    number of reloads to a minimum.
    sttts committed Oct 19, 2014
    Configuration menu
    Copy the full SHA
    10b5a28 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2014

  1. Configuration menu
    Copy the full SHA
    6c0e875 View commit details
    Browse the repository at this point in the history