expose service port from marathon REST API

[rasputnik]

Closes #37.

[rasputnik]

Also just realised the main readme shows config that's no longer used, so I've cleaned that out
(happy to redo this as 2 PRs if you'd prefer).

[j1n6]

You can squash commits.

Sent from my iPhone

On 10 Oct 2014, at 21:07, Dick Davies notifications@github.com wrote:

Also just realised the main readme shows config that's no longer used, so I've cleaned that out
(happy to redo this as 2 PRs if you'd prefer).

—
Reply to this email directly or view it on GitHub.

[rasputnik]

Done, sorry about that!

[j1n6]

Looks good. Thanks for the fmt correction.
Do you mind adding a usage comment in haproxy template? (in case other users have same similar requirement)

[rasputnik]

do you want a full example template (haproxy-legacy.cfg.tmpl ?) or shall I just add a section to the existing template?

On 10 Oct 2014, at 21:43, Jing Dong notifications@github.com wrote:

Looks good. Thanks for the fmt correction.
Do you mind adding a usage comment in haproxy template? (in case other users have same similar requirement)

—
Reply to this email directly or view it on GitHub.

[j1n6]

I think adding a commented example or description in existing template is
good enough.
Make sure it's commented out so that the current default behaviour stays
the same.
Thanks!

On 10 October 2014 21:47, Dick Davies notifications@github.com wrote:

do you want a full example template (haproxy-legacy.cfg.tmpl ?) or shall I
just add a section to the existing template?

On 10 Oct 2014, at 21:43, Jing Dong notifications@github.com wrote:

Looks good. Thanks for the fmt correction.
Do you mind adding a usage comment in haproxy template? (in case other
users have same similar requirement)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#38 (comment).

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else, please
erase all copies and attachments, and please let me know that it has gone to

the wrong person. Thanks.

[rasputnik]

Will do - in same PR, or a new one?

On 10 October 2014 21:55, Jing Dong notifications@github.com wrote:

I think adding a commented example or description in existing template is
good enough.
Make sure it's commented out so that the current default behaviour stays
the same.
Thanks!

On 10 October 2014 21:47, Dick Davies notifications@github.com wrote:

do you want a full example template (haproxy-legacy.cfg.tmpl ?) or shall
I
just add a section to the existing template?

On 10 Oct 2014, at 21:43, Jing Dong notifications@github.com wrote:

Looks good. Thanks for the fmt correction.
Do you mind adding a usage comment in haproxy template? (in case other
users have same similar requirement)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#38 (comment).

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else, please
erase all copies and attachments, and please let me know that it has gone
to

the wrong person. Thanks.

—
Reply to this email directly or view it on GitHub
#38 (comment).

[j1n6]

same PR would be good :)
Btw, thanks for correcting the README, that was my bad not correcting it.

On 10 October 2014 22:06, Dick Davies notifications@github.com wrote:

Will do - in same PR, or a new one?

On 10 October 2014 21:55, Jing Dong notifications@github.com wrote:

I think adding a commented example or description in existing template
is
good enough.
Make sure it's commented out so that the current default behaviour stays
the same.
Thanks!

On 10 October 2014 21:47, Dick Davies notifications@github.com wrote:

do you want a full example template (haproxy-legacy.cfg.tmpl ?) or
shall
I
just add a section to the existing template?

On 10 Oct 2014, at 21:43, Jing Dong notifications@github.com
wrote:

Looks good. Thanks for the fmt correction.
Do you mind adding a usage comment in haproxy template? (in case
other
users have same similar requirement)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#38 (comment).

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else, please
erase all copies and attachments, and please let me know that it has
gone
to

the wrong person. Thanks.

—
Reply to this email directly or view it on GitHub
#38 (comment).

—
Reply to this email directly or view it on GitHub
#38 (comment).

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else, please
erase all copies and attachments, and please let me know that it has gone to

the wrong person. Thanks.

[rasputnik]

No problem - on its way.

On 10 October 2014 22:08, Jing Dong notifications@github.com wrote:

same PR would be good :)
Btw, thanks for correcting the README, that was my bad not correcting it.

On 10 October 2014 22:06, Dick Davies notifications@github.com wrote:

Will do - in same PR, or a new one?

On 10 October 2014 21:55, Jing Dong notifications@github.com wrote:

I think adding a commented example or description in existing template
is
good enough.
Make sure it's commented out so that the current default behaviour
stays
the same.
Thanks!

On 10 October 2014 21:47, Dick Davies notifications@github.com
wrote:

do you want a full example template (haproxy-legacy.cfg.tmpl ?) or
shall
I
just add a section to the existing template?

On 10 Oct 2014, at 21:43, Jing Dong notifications@github.com
wrote:

Looks good. Thanks for the fmt correction.
Do you mind adding a usage comment in haproxy template? (in case
other
users have same similar requirement)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
<
https://github.com/QubitProducts/bamboo/pull/38#issuecomment-58714087>.

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else,
please
erase all copies and attachments, and please let me know that it has
gone
to

the wrong person. Thanks.

—
Reply to this email directly or view it on GitHub
#38 (comment).

—
Reply to this email directly or view it on GitHub
#38 (comment).

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else, please
erase all copies and attachments, and please let me know that it has gone
to

the wrong person. Thanks.

—
Reply to this email directly or view it on GitHub
#38 (comment).

[j1n6]

@rasputnik Thanks for contributing!