Fix broken tests in order to keep in sync with upstream (#24)

* Update badge link * version bump * Sync with upstream constructor * Sync with upstream constructor * Sync with upstream constructor
QubitPi · Nov 22, 2023 · d97e8d0 · d97e8d0
1 parent de81616
commit d97e8d0
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # Neo4j Browser <sup>![Node Version Badge is Missing][node version badge]</sup>
 
-[![npm registry][npm registry]](https://img.shields.io/npm/v/neo4j-devtools-arc?logo=npm&style=for-the-badge)
+[![npm registry][npm registry]](https://www.npmjs.com/package/neo4j-devtools-arc)
 
 Neo4j Browser is the general purpose graphical user interface for Neo4j. Query, visualize, administer and monitor the database with modern and easy-to-use tools.
 

diff --git a/e2e_tests/integration/viz.spec.ts b/e2e_tests/integration/viz.spec.ts
@@ -278,7 +278,7 @@ describe('Viz rendering', () => {
       .trigger('mouseenter', { force: true })
       .get('[data-testid="viz-details-pane-properties-table"]')
       .find('td:nth-child(1)')
-      .should('have.text', '<id>descriptionname')
+      .should('have.text', '<elementId><id>descriptionname')
 
     cy.executeCommand('MATCH (n) DETACH DELETE n')
   })

diff --git a/.../modules/Stream/CypherFrame/VisualizationView/PropertiesPanelContent/DetailsPane.test.tsx b/.../modules/Stream/CypherFrame/VisualizationView/PropertiesPanelContent/DetailsPane.test.tsx
@@ -73,8 +73,8 @@ describe('<DetailsPane />', () => {
             elementId: 'abc',
             type: 'abc2',
             propertyList,
-            source: new NodeModel('1', [], {}, {}),
-            target: new NodeModel('2', [], {}, {})
+            source: new NodeModel('1', [], {}, {}, '1'),
+            target: new NodeModel('2', [], {}, {}, '1')
           }
         }
     }

diff --git a/src/neo4j-arc/common/components/PropertiesTable/PropertiesTable.test.tsx b/src/neo4j-arc/common/components/PropertiesTable/PropertiesTable.test.tsx
@@ -65,8 +65,8 @@ describe('<DetailsPane />', () => {
             elementId: 'abc',
             type: 'abc2',
             propertyList,
-            source: new NodeModel('1', [], {}, {}),
-            target: new NodeModel('2', [], {}, {})
+            source: new NodeModel('1', [], {}, {}, '1'),
+            target: new NodeModel('2', [], {}, {}, '2')
           }
         }
     }

diff --git a/...j-arc/graph-visualization/GraphVisualizer/DefaultPanelContent/DefaultDetailsPane.test.tsx b/...j-arc/graph-visualization/GraphVisualizer/DefaultPanelContent/DefaultDetailsPane.test.tsx
@@ -74,8 +74,8 @@ describe('<DetailsPane />', () => {
             elementId: 'elementId',
             type: 'abc2',
             propertyList,
-            source: new NodeModel('1', [], {}, {}),
-            target: new NodeModel('2', [], {}, {})
+            source: new NodeModel('1', [], {}, {}, '1'),
+            target: new NodeModel('2', [], {}, {}, '2')
           }
         }
     }

diff --git a/src/neo4j-arc/graph-visualization/GraphVisualizer/Graph/GraphEventHandlerModel.ts b/src/neo4j-arc/graph-visualization/GraphVisualizer/Graph/GraphEventHandlerModel.ts
@@ -258,7 +258,8 @@ export class GraphEventHandlerModel {
         {
           name: 'string',
           description: 'string'
-        }
+        },
+        transientId
       )
     ])
     this.visualization.update({ updateNodes: true, updateRelationships: true })
@@ -306,7 +307,8 @@ export class GraphEventHandlerModel {
         this.altCreatedRelTargetNode,
         transientId,
         { name: 'new link' },
-        { name: 'string' }
+        { name: 'string' },
+        transientId
       )
 
       this.graph.addRelationships([altCreatedRel])

diff --git a/src/neo4j-arc/graph-visualization/GraphVisualizer/GraphVisualizer.test.tsx b/src/neo4j-arc/graph-visualization/GraphVisualizer/GraphVisualizer.test.tsx
@@ -33,7 +33,8 @@ describe('<GraphVisualizer />', () => {
       propertyTypes: {
         name: 'string',
         age: 'number'
-      }
+      },
+      elementId: '1'
     },
     {
       id: '2',
@@ -43,7 +44,8 @@ describe('<GraphVisualizer />', () => {
       },
       propertyTypes: {
         name: 'string'
-      }
+      },
+      elementId: '2'
     }
   ]
   const links: BasicRelationship[] = [
@@ -53,7 +55,8 @@ describe('<GraphVisualizer />', () => {
       endNodeId: '2',
       type: 'likes',
       properties: {},
-      propertyTypes: {}
+      propertyTypes: {},
+      elementId: '3'
     }
   ]
 

diff --git a/src/neo4j-arc/package.json b/src/neo4j-arc/package.json
@@ -1,6 +1,6 @@
 {
   "name": "neo4j-devtools-arc",
-  "version": "0.0.55",
+  "version": "0.0.56",
   "main": "dist/neo4j-arc.js",
   "author": "Neo4j Inc.",
   "license": "GPL-3.0",