Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add win10/11 and builderv2 support #6

Open
wants to merge 81 commits into
base: master
Choose a base branch
from
Open

Add win10/11 and builderv2 support #6

wants to merge 81 commits into from

Conversation

omeg
Copy link
Member

@omeg omeg commented Mar 7, 2025 •
edited by marmarek
Loading

This is a substantial rewrite for win10 compatibility (no custom legacy video driver - no Windows 7 support). We now use the DirectX output duplication interface to detect changes and framebuffer is shared with the gui daemon via proper grants instead of PFNs.

Lots of fixes and tweaks in the window tracking logic were needed and it's still far from perfect. It seems that in win10 all the normal WINAPI functions used to get basic window properties like size/coordinates etc are increasingly unreliable and returning objectively wrong values. This is probably due to increasing use of hardware compositing, but DWM (the compositor) doesn't expose any APIs to get its accurate internal state.

The next step (after some more basic fixes) is definitely a full custom WDDM video driver. This will give us more control over the framebuffer and more accurate change detection. It might improve window detection, but the driver will not know anything about the userland desktop layout, it will just manage textures that will somehow needed to be matched to actual windows. I think hooking into the internal DWM state is needed for accurate window representation...

QubesOS/qubes-issues#1861

omeg added 30 commits June 25, 2023 13:44
@omeg
Initial Win10 version (see README)
065fe6f 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix initial bugs, use DXGI dirty rects
1eb9f28 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Remove FPS throttling
2f1c32c 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
win10: remove the need for MemoryLock
dff1d18 
MemoryLock functionality was upstreamed to xeniface in commit 4662c78.
This commit also fixes some bugs and removes unused files.

Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Update gitignore
ae5bec9 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Support building from the installer
9dd6b5c 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Remove per-frame logs from DEBUG level
4f641f3 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Remove unused define
786d687 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Add missing include to VS project
20031db 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Rename watchdog project
1381686 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Add test utility to dump detailed window information
e3ceeb6 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Improve filtering unwanted windows
62968cf 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Remove some debug logging
700924b 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Refactor and a lot of bugfixes
52c6680 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix incorrect damage rect calculation
fadb6d9 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix synchronization-related crash
766d645 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix off-by-one errors in window sizes
89e36bb 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Minor logging improvement
c4bfe3f 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Properly detect destroyed windows
3833a22 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
capture: lock frame access with a critical section
1d9a020 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
capture: log damage rects in debug build
06acde4 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix minimized windows bookkeeping
56d261b 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
debug: don't log window list in fullscreen mode
dccdcca 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Improve window size tracking
5b54614 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
watchdog: reduce time delay to respawn gui agent
835e0e2 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Make project outputs separate to eliminate postbuild copy overlap
45d61c9 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
dump-windows: run in a loop until terminated
dad9387 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
debug: add parent to window list dump
fecb26a 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
More window tracking improvements, fix for start menu/search
927ad37 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
debug: add disableWindowFiltering manifest option to dump-windows
fca2e81 
This allows for proper capturing of UWP/immersive/metro apps

Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
omeg and others added 30 commits April 18, 2024 18:17
@omeg
windows: add libvchan_cleanup() for xenstore path removal
a11e3cf 
This is needed if waiting for a vchan event manually instead of using libvchan_wait().

Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Add logging transient_for value in SendWindowMap()
0806050 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix simulating SAS (CTRL+ALT+DEL), use CTRL+SHIFT+DEL
7d453d0 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Remove unneeded calls in HandleFocus()
80ab611 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix debug log format
e912c23 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Log synthesised keys by name
fa3dc89 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Add missing library dependency to the project
a5ed85c 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix edge case in HandleMotion()
96a6264 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
More improvements for iconic windows, especially UAC prompts
65b5785 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Remove unnecessary callback
96f117a 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix locking in server msg handlers
a33a8cf 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Tune window accepting algorithm
3af8417 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix keycode names for debug
451eaca 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Properly handle fullscreen resolution changes
6ed4679 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Remove redundant TODOs from the readme
72cb484 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Add more safeguards for enumerating display modes
60c8d28 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix potentially uninitialized variable
833f4d8 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix a corner case in message ordering
c31e160 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix corner cases in popup handling
d38e447 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Increase warning level, use c17
91dd677 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Clean up includes, remove globally disabled warning
ed6dc37 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Preserve last-set fullscreen resolution
4aff4dd 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix incorrect payload size in vchan messages
adfc1fe 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Send proper protocol version
f7b66d1 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Rename readme
1a43589 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Support builder v2
4e8e38b 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Version 4.2.0
27b93df 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Fix local build
0ad0aa9 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@omeg
Update gitignore
25f5cf1 
Signed-off-by: Rafał Wojdyła <omeg@invisiblethingslab.com>
@marmarek
ci: switch to R4.3
f84b898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omeg @marmarek