remove type piracy methods #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Codecov ReportBase: 89.03% // Head: 88.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 89.03% 88.90% -0.14%
==========================================
Files 13 13
Lines 757 739 -18
==========================================
- Hits 674 657 -17
+ Misses 83 82 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks you for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in internals, this package (and packages that use it) will error on 1.8.4 when testing. Due to
@inboundsthey will actually probably have memory corruption in normal usage.The failures can be seen at https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/992d4ca_vs_0434deb/report.html.
It would be good to get a new version out somewhat quickly (at least before 1.8.4 is properly released)
Fixes #57.
cc @GiggleLiu, @Roger-luo