-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pixi #384
Switch to pixi #384
Conversation
Since submitting this PR the a new version of pixi has been released, which supports passing the
What do you think @pavelzw? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left 2 questions regarding the CI setup, but otherwise looks good. Tested on my mac and everything works perfectly.
Regarding the switch to the no-build-isolation using pixi, how slow does it make the package resolution? Is it going from like 10 seconds to 2 minutes, or from 10 seconds to 15 seconds? If it's the latter, then I'm absolutely okay with that. For the rebuild, either we can keep the post-install task or rename it to "rebuild". Also, as this is only relevant for deep development, we can also instruct the contributors to remove the lock file and start from scratch. |
If we make this change then pixi has to install an environments before being able to make the final solve. I did some testing: this means that from starting from scratch, environment resolution (e.g. when adding a new package) takes ~2 minutes on my laptop. Another issue is that these environments take up a lot of space (11 gigs). After all environments are installed, resolution is reasonably fast (e.g. adding a package takes around 10-15 seconds. I'd say making devs install all environments when they want to add a dependency is too big of a tradeoff (especially in terms of disk space) for being able to omit postinstall. I would wait until pixi gets a
Good point! Even though I would not make the switch just yet, it would be a perfect solution when we do. |
xref prefix-dev/pixi#1046 |
Checklist
CHANGELOG.rst
entrySimilarly to glum #802, this migrates the dev installation to pixi. It's more or less the same, so see that PR for the discussion.
TODO:
benchmark-analyze
(although I don't think it is a pixi issue)