Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ruff instead of black, isort, and flake8 #141

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Use ruff instead of black, isort, and flake8 #141

merged 3 commits into from
Mar 5, 2024

Conversation

cbourjau
Copy link
Collaborator

This PR replaces black, isort, and flake8 with ruff. Ruff does a great job removing unused imports in our opsets. There are some other minor formatting changes that I think are not worth the trouble of diverging from the default settings.

Supersedes #133

Replace black, isort, and flake8 with ruff. Ruff does a great job removing
unused imports in our opsets. Supersedes #133
@jbachurski
Copy link
Collaborator

Looks good 🚀
However, I'm not super familiar with the ruff configuration details, maybe someone else can take a look to approve.

@cbourjau
Copy link
Collaborator Author

cbourjau commented Mar 4, 2024

@adityagoel4512 Would you like to do the honors unless you see something amiss? Given that the config is quite defaulty and the diff is reasonably small I'd be happy to just see how it works out.

Copy link
Member

@adityagoel4512 adityagoel4512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really in the scope of this PR but it would be great if we could address the attribute reference type hinting (e.g. by updating the opset generation).

Co-authored-by: Aditya Goel <48102515+adityagoel4512@users.noreply.github.com>
@cbourjau
Copy link
Collaborator Author

cbourjau commented Mar 5, 2024

The attribute references are still private which is the reason why they are not in the public interface. On the other hand, maybe it is time to stabilize ONNX functions in Spox now that their support in the onnxruntime seems to have matured (even though I consider them pretty broken and useless in the standard).

@cbourjau cbourjau merged commit 85fba6f into main Mar 5, 2024
12 checks passed
@cbourjau cbourjau deleted the use-ruff branch March 5, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants