Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add todo_nodes sort to maintain deterministic output in token_swapper #897

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

enavarro51
Copy link
Contributor

This PR adds a sort to the todo_nodes Vec in token_swapper in order to maintain deterministic output when using a seed. This problem appeared when implementing Qiskit/qiskit#10001 and some of the tests produced correct, but random output.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5222916748

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.456%

Totals Coverage Status
Change from base Build 5221530590: 0.02%
Covered Lines: 14995
Relevant Lines: 15546

💛 - Coveralls

@mtreinish mtreinish added this to the 0.13.1 milestone Jun 9, 2023
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for the quick fix

@mtreinish mtreinish added automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch labels Jun 9, 2023
@mergify mergify bot merged commit af4af62 into Qiskit:main Jun 9, 2023
mergify bot pushed a commit that referenced this pull request Jun 9, 2023
(cherry picked from commit af4af62)
mergify bot added a commit that referenced this pull request Jun 9, 2023
(cherry picked from commit af4af62)

Co-authored-by: Edwin Navarro <enavarro@comcast.net>
1ucian0 added a commit to 1ucian0/qiskit-terra that referenced this pull request Feb 11, 2024
github-merge-queue bot pushed a commit to Qiskit/qiskit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants