Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support of sequence protocol for returned lists #730

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Fix support of sequence protocol for returned lists #730

merged 2 commits into from
Nov 9, 2022

Commits on Nov 7, 2022

  1. Fix support of sequence protocol for returned lists 

    Add the `sequence` option to PyO3's `pyclass`, so that the `sq_length`
slot is implemented [1]. Implementing this method is required for
sequence types, or Python C API functions like `PySequence_Size` will
fail with an error.

The `reversed` built-in method relies on `PySequence_*` methods. A test
reversing `NodeIndices` is added to guard against future violations of
the sequence protocol.

Fixes Qiskit#696.

[1]: PyO3/pyo3#2567
    @tuxu
    tuxu committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f95aecd View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Add release note

    @mtreinish
    mtreinish committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b4349a3 View commit details
    Browse the repository at this point in the history