Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy error with new Rust 1.65 release #725

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

mtreinish
Copy link
Member

Rust 1.65 was recently released which added some new clippy rules. This commit fixes the failure reported when running clippy with 1.65. This would have caused a CI failure as we start using the new rust version in CI.

Rust 1.65 was recently released which added some new clippy rules. This
commit fixes the failure reported when running clippy with 1.65. This
would have caused a CI failure as we start using the new rust version
in CI.
@mtreinish mtreinish added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Nov 3, 2022
@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Nov 3, 2022
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems straightforward

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3389061842

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 96.993%

Totals Coverage Status
Change from base Build 3379453299: 0.06%
Covered Lines: 13644
Relevant Lines: 14067

💛 - Coveralls

@mergify mergify bot merged commit 9ce8d4d into Qiskit:main Nov 4, 2022
mergify bot pushed a commit that referenced this pull request Nov 4, 2022
Rust 1.65 was recently released which added some new clippy rules. This
commit fixes the failure reported when running clippy with 1.65. This
would have caused a CI failure as we start using the new rust version
in CI.

(cherry picked from commit 9ce8d4d)
mergify bot added a commit that referenced this pull request Nov 4, 2022
* Fix clippy error with new Rust 1.65 release (#725)

Rust 1.65 was recently released which added some new clippy rules. This
commit fixes the failure reported when running clippy with 1.65. This
would have caused a CI failure as we start using the new rust version
in CI.

(cherry picked from commit 9ce8d4d)

* Switch from Python 3.11rc to official release (#714)

* Switch from Python 3.11rc to official release

* Move extras to root testenv

(cherry picked from commit cd1934d)

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Co-authored-by: Ivan Carvalho <ivancarv@student.ubc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants