-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generalized Petersen graphs generator #497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1517189461
💛 - Coveralls |
georgios-ts
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
georgios-ts
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the updates.
e-eight
pushed a commit
to e-eight/retworkx
that referenced
this pull request
Dec 5, 2021
* Add generalized_petersen_graph * Add errors for invalid n and k * Fix test * Formatting * Update docstring * Add tests * Update docstring * Add release note * Add entry to api.rst * Formatting * Address clippy * Address flake8 comment * Improve docs * Update src/generators.rs Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com> * Address PR comments Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #150
Add a generator for generalized Petersen graphs 1. That family of graphs has many interesting mathematical properties, and could be useful for both users and retworkx developers. This PR also adds test cases to our isomorphism code based on properties of those Petersen graphs.