Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generalized Petersen graphs generator #497

Merged
merged 15 commits into from
Nov 30, 2021

Conversation

IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented Nov 27, 2021

Related to #150

Add a generator for generalized Petersen graphs 1. That family of graphs has many interesting mathematical properties, and could be useful for both users and retworkx developers. This PR also adds test cases to our isomorphism code based on properties of those Petersen graphs.

@IvanIsCoding IvanIsCoding added this to the 0.11.0 milestone Nov 27, 2021
@coveralls
Copy link

coveralls commented Nov 27, 2021

Pull Request Test Coverage Report for Build 1517189461

  • 40 of 40 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 98.424%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 2 98.77%
Totals Coverage Status
Change from base Build 1491319329: 0.06%
Covered Lines: 10678
Relevant Lines: 10849

💛 - Coveralls

Copy link
Collaborator

@georgios-ts georgios-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/generators.rs Outdated Show resolved Hide resolved
src/generators.rs Outdated Show resolved Hide resolved
tests/generators/test_petersen.py Outdated Show resolved Hide resolved
src/generators.rs Show resolved Hide resolved
src/generators.rs Outdated Show resolved Hide resolved
IvanIsCoding and others added 2 commits November 29, 2021 09:04
Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
Copy link
Collaborator

@georgios-ts georgios-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates.

@georgios-ts georgios-ts merged commit 7349a96 into Qiskit:main Nov 30, 2021
e-eight pushed a commit to e-eight/retworkx that referenced this pull request Dec 5, 2021
* Add generalized_petersen_graph

* Add errors for invalid n and k

* Fix test

* Formatting

* Update docstring

* Add tests

* Update docstring

* Add release note

* Add entry to api.rst

* Formatting

* Address clippy

* Address flake8 comment

* Improve docs

* Update src/generators.rs

Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>

* Address PR comments

Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
@IvanIsCoding IvanIsCoding deleted the petersen-graph branch January 4, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants