Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow partial kwargs in mpl_draw #1180

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Allow partial kwargs in mpl_draw #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d635ceb
Allow partial kwargs in mpl_draw
IvanIsCoding Apr 30, 2024
b6e6471
Add release note as well
IvanIsCoding Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions releasenotes/notes/fix-mpl-draw-kargs-typing-6cf7cfde0db072d5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fixes:
- |
Fixed a bug in the type hint for the :func:`~rustworkx.visualization.mpl_draw`.
Previously, all `kwargs` were required when calling the method. The new annotation
accepts `kwargs` with partial arguments.
2 changes: 1 addition & 1 deletion rustworkx/visualization/matplotlib.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if typing.TYPE_CHECKING:
_S = typing.TypeVar("_S")
_T = typing.TypeVar("_T")

class _DrawKwargs(typing.TypedDict):
class _DrawKwargs(typing.TypedDict, total=False):
arrowstyle: str
arrow_size: int
node_list: list[int]
Expand Down
Loading