Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease graphviz visualization test size to speed up tests #1153

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

mtreinish
Copy link
Member

With recent graphviz releases the graphviz_draw() visualization tests for 50 node random graphs were taking an inordinate amount of time. This didn't seem to be an issue in CI but on my local system with graphviz 10.0.1 the time for graphviz to generate a visualization for the 50 node random graph was orders of magnitude slower than the rest of the tests in the rustworkx python tests. This commit decreases the graph size to only be 10 nodes, which reduces the runtime of these tests to be inline with expectations.

With recent graphviz releases the graphviz_draw() visualization tests
for 50 node random graphs were taking an inordinate amount of time. This
didn't seem to be an issue in CI but on my local system with graphviz
10.0.1 the time for graphviz to generate a visualization for the 50 node
random graph was orders of magnitude slower than the rest of the tests
in the rustworkx python tests. This commit decreases the graph size to
only be 10 nodes, which reduces the runtime of these tests to be inline
with expectations.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8512442232

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.503%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 6 95.53%
Totals Coverage Status
Change from base Build 8470915706: -0.03%
Covered Lines: 17136
Relevant Lines: 17757

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, as long as we cover all the lines we should be fine.

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Apr 1, 2024
@mergify mergify bot merged commit bd98b65 into Qiskit:main Apr 1, 2024
30 checks passed
@mtreinish mtreinish deleted the speed-up-graphviz-draw-tests branch April 1, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants