Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run clippy CI job on all targets #1057

Merged
merged 3 commits into from
Jan 17, 2024
Merged

run clippy CI job on all targets #1057

merged 3 commits into from
Jan 17, 2024

Conversation

danieleades
Copy link
Contributor

configures the clippy CI job to run on all targets and addresses all existing clippy::all errors and warnings

IvanIsCoding
IvanIsCoding approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward. Thanks for adding the flag and the fixes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7546663503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 95.959%
Totals Coverage Status
Change from base Build 7545335757: 0.04%
Covered Lines: 16030
Relevant Lines: 16705
💛 - Coveralls

@IvanIsCoding IvanIsCoding merged commit fe6666d into Qiskit:main Jan 17, 2024
25 checks passed
@danieleades danieleades deleted the clippy/all-targets branch January 17, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieleades @coveralls @IvanIsCoding