Fix margin bug at bottom of lists #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
changed the title
Eric-Arellano
approved these changes
Mar 17, 2023
|
@HuangJunye please review and merge this if you're comfortable, since both Abby and I are OOO next week. cc @coruscating Note that I expanded Abby's fix to also fix the issue I discovered with nested unordered list. Abby's code made it clear how to do that - thanks Abby! |
|
@javabster can you please double check that you agree with my changes, and then merge? |
Eric-Arellano
added a commit
to Eric-Arellano/qiskit_sphinx_theme
that referenced
this pull request
Apr 4, 2023
Fixes Qiskit#201. As described there, we had two issues: 1. For ordered lists, there was no margin underneath it. 2. For unordered lists, we were adding a margin inside nested list elements, which was not intended. We only want to add a margin at the very end of the outer-most list. This is fixed by only applying the margin to the elements `article.pytorch-article ol` and `article.pytorch-article ul`, which only apply to the outer most list. ## Before: <img width="472" alt="Screenshot 2023-03-17 at 11 29 35 AM" src="https://user-images.githubusercontent.com/23662430/225805307-76c22599-35b0-42a3-a57d-4db8cfc77708.png"> --  ## After: <img width="474" alt="Screenshot 2023-03-17 at 11 28 30 AM" src="https://user-images.githubusercontent.com/23662430/225805322-53ed87a4-c70a-4254-808f-3cd9addf46fe.png"> --  --------- Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Eric-Arellano
added a commit
that referenced
this pull request
Apr 4, 2023
Fixes #201. As described there, we had two issues: 1. For ordered lists, there was no margin underneath it. 2. For unordered lists, we were adding a margin inside nested list elements, which was not intended. We only want to add a margin at the very end of the outer-most list. This is fixed by only applying the margin to the elements `article.pytorch-article ol` and `article.pytorch-article ul`, which only apply to the outer most list. ## Before: <img width="472" alt="Screenshot 2023-03-17 at 11 29 35 AM" src="https://user-images.githubusercontent.com/23662430/225805307-76c22599-35b0-42a3-a57d-4db8cfc77708.png"> --  ## After: <img width="474" alt="Screenshot 2023-03-17 at 11 28 30 AM" src="https://user-images.githubusercontent.com/23662430/225805322-53ed87a4-c70a-4254-808f-3cd9addf46fe.png"> --  --------- Co-authored-by: Abby Mitchell <23662430+javabster@users.noreply.github.com>
coruscating
added a commit
to qiskit-community/qiskit-experiments
that referenced
this pull request
Apr 10, 2023
### Summary This PR follows Qiskit/qiskit#9705 to remove the dependency on `sphinx-autodoc-typehints` and Qiskit/qiskit-metapackage#1707 to use the default Qiskit icon when the experiment manual isn't explicitly provided. ### Details and comments In addition, some experiment classes that didn't link to their manuals have been updated with the link. Manual line breaks added after numbered lists have been removed now that Qiskit/qiskit_sphinx_theme#218 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201. As described there, we had two issues:
This is fixed by only applying the margin to the elements
article.pytorch-article olandarticle.pytorch-article ul, which only apply to the outer most list.Before:
--
After:
--