Wrap io::Error in QASM2ParseError on failed file read
#9958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if Python thought the target file for `qasm2.load` existed, but Rust was unable to open it, the result `io:Error` would be propagated up to Python space verbatim, and these situations usually have confusing error messages. This could happen, for example, if the target was a directory on Windows.
jakelishman
added
mod: qasm2
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4688938813
💛 - Coveralls |
Eric-Arellano
approved these changes
Apr 13, 2023
mtreinish
approved these changes
Apr 13, 2023
| lex::TokenStream::from_path(path, strict)?, | ||
| lex::TokenStream::from_path(&path, strict).map_err(|err| { | ||
| let exc = QASM2ParseError::new_err(format!( | ||
| "failed to read a token stream from file '{}'", |
There was a problem hiding this comment.
Super minor nitpick, you don't want to start this with a capital f?
Suggested change
| "failed to read a token stream from file '{}'", | |
| "Failed to read a token stream from file '{}'", |
There was a problem hiding this comment.
That's actually what I originally typed, but it turns out that I started all my other error messages with lower-case letters, which matches Python's built-in style.
giacomoRanieri
pushed a commit
to giacomoRanieri/qiskit-terra
that referenced
this pull request
Apr 16, 2023
Previously, if Python thought the target file for `qasm2.load` existed, but Rust was unable to open it, the result `io:Error` would be propagated up to Python space verbatim, and these situations usually have confusing error messages. This could happen, for example, if the target was a directory on Windows.
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
Previously, if Python thought the target file for `qasm2.load` existed, but Rust was unable to open it, the result `io:Error` would be propagated up to Python space verbatim, and these situations usually have confusing error messages. This could happen, for example, if the target was a directory on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, if Python thought the target file for
qasm2.loadexisted, but Rust was unable to open it, the resultio:Errorwould be propagated up to Python space verbatim, and these situations usually have confusing error messages. This could happen, for example, if the target was a directory on Windows.Details and comments
Detected while doing #9955 preparing for 0.25. This PR is a bugfix for #9784, though, so wants to be in 0.24.