Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in QuantumCircuit.draw related to vertical_compression #9855

Merged
merged 6 commits into from
Apr 3, 2023
Merged

Fix a bug in QuantumCircuit.draw related to vertical_compression #9855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
627c404
Fix a bug in QuantumCircuit.draw related to vertical_compression
rainij Mar 25, 2023
a4c9de4
Update tests so that they would catch the bug
rainij Mar 26, 2023
62b8496
Fix black-errors
rainij Mar 26, 2023
bdd7589
Remove TODO comment
rainij Mar 26, 2023
45b0d85
Add release note
rainij Apr 1, 2023
6d0d848
Fixup release note
jakelishman Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qiskit/visualization/circuit/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@ def merge_lines(top, bot, icod="top"):
ret += "│"
elif topc == "└" and botc == "┌" and icod == "top":
ret += "├"
elif topc == "┘" and botc == "┐":
elif topc == "┘" and botc == "┐" and icod == "top":
ret += "┤"
elif botc in "┐┌" and icod == "top":
ret += "┬"
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/fix-circuit-drawing-low-compression-965c21de51b26ad2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Fixed the top-right corner of gates when using ``vertical_compression="low"`` in text visualizations of circuits.
32 changes: 26 additions & 6 deletions test/python/visualization/test_circuit_text_drawer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1988,22 +1988,32 @@ def test_text_conditional_reverse_bits_true(self):
[
" ┌───┐ ┌─┐ ┌───┐",
"qr_2: |0>┤ H ├─────┤M├─────┤ X ├",
" ├───┤ └╥┘ └─╥─┘",
" └───┘ └╥┘ └─╥─┘",
" ┌───┐ ║ ║ ",
"qr_1: |0>┤ H ├──────╫────────╫──",
" ├───┤┌───┐ ║ ┌───┐ ║ ",
" └───┘ ║ ║ ",
" ┌───┐┌───┐ ║ ┌───┐ ║ ",
"qr_0: |0>┤ H ├┤ X ├─╫─┤ X ├──╫──",
" └───┘└───┘ ║ └───┘ ║ ",
" ║ ║ ",
" cr2: 0 ═══════════╬════════╬══",
" ║ ║ ",
" ║ ║ ",
" cr_1: 0 ═══════════╩════════■══",
" ║ ",
" ║ ",
" cr_0: 0 ════════════════════o══",
" 0x2 ",
]
)

self.assertEqual(
str(_text_circuit_drawer(circuit, cregbundle=False, reverse_bits=True)), expected
str(
_text_circuit_drawer(
circuit, vertical_compression="low", cregbundle=False, reverse_bits=True
)
),
expected,
)

def test_text_conditional_reverse_bits_false(self):
Expand All @@ -2024,22 +2034,32 @@ def test_text_conditional_reverse_bits_false(self):
[
" ┌───┐┌───┐┌───┐",
"qr_0: |0>┤ H ├┤ X ├┤ X ├",
" ├───┤└───┘└───┘",
" └───┘└───┘└───┘",
" ┌───┐ ",
"qr_1: |0>┤ H ├──────────",
" ├───┤ ┌─┐ ┌───┐",
" └───┘ ",
" ┌───┐ ┌─┐ ┌───┐",
"qr_2: |0>┤ H ├─┤M├─┤ X ├",
" └───┘ └╥┘ └─╥─┘",
" ║ ║ ",
" cr_0: 0 ═══════╬════o══",
" ║ ║ ",
" ║ ║ ",
" cr_1: 0 ═══════╩════■══",
" 0x2 ",
" ",
" cr2: 0 ═══════════════",
" ",
]
)

self.assertEqual(
str(_text_circuit_drawer(circuit, cregbundle=False, reverse_bits=False)), expected
str(
_text_circuit_drawer(
circuit, vertical_compression="low", cregbundle=False, reverse_bits=False
)
),
expected,
)

def test_text_justify_right(self):
Expand Down