Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing error in random_circuit conditionals (backport #9651) #9656

Merged
merged 2 commits into from
Feb 24, 2023

Commits on Feb 24, 2023

  1. Fix typing error in random_circuit conditionals (#9651)

    The `condition` field is expected to be a comparison of a register or
    bit with a Python bigint (or bool, which is a subclass).  This function
    could previously output fixed-width Numpy types, however, which could
    cause problems with subsequent bitmasks if the constructed masker/maskee
    _was_ a Python bigint and couldn't fit in the Numpy type.  The more
    recent `IfElseOp` enforces the correct typing, it's just the old form
    that doesn't.
    
    Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
    (cherry picked from commit 94e9480)
    jakelishman authored and mergify[bot] committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    3fb23e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e6a972e View commit details
    Browse the repository at this point in the history