Added pulses to the SymbolicPulse library
#9625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4235675563
💛 - Coveralls |
nkanazawa1989
requested changes
Feb 20, 2023
There was a problem hiding this comment.
Thanks @TsafrirA this looks almost in good shape. Glad to see the growth of pulse library :)
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
nkanazawa1989
approved these changes
Feb 21, 2023
nkanazawa1989
added
mod: pulse
Eric-Arellano
pushed a commit
to Eric-Arellano/qiskit-terra
that referenced
this pull request
Feb 23, 2023
* Corrected library pulses return types. * Added Sin and Cos Pulses * Add sawtooth pulse * Add triangle pulse * Add new pulses to _init_ and some corrections * Add tests, release notes and some corrections. * Release notes correction * Documentation correction * Update qiskit/pulse/library/symbolic_pulses.py Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> * Some corrections and modifications --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The old library of discrete pulses included several pulse types which were not present in the
SymbolicPulselibrary. These pulses includeSin,Cos,SawtoothandTriangle, which were added now to theSymbolicPulselibrary.Details and comments
The
SymbolicPulselibrary was extended to include 4 new pulse types:SinCosSawtoothTriangleWith the exception of the
Sawtoothphase parameter, the behavior is identical to the corresponding discrete pulses. The phase parameter ofSawtoothwas modified such that a 2\pi phase shift will result in a full cycle shift, and not a \pi shift, as is the case in the discrete pulsesawtooth.Following the example set by #9329, the pulses are introduced as functions, but their names are capitalized to match the old pulses.
The new pulses were not introduced to the
qpy_compattest. To do that, the test would have to be split into several versions, according to the availability of different pulses in different releases. (Some versioning will be required anyway once the deprecation of complex amplitude will be completed - #9002)