Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an equiv method to the StabilizerState class #9543

Merged
merged 9 commits into from
Feb 8, 2023

Conversation

ShellyGarion
Copy link
Member

Summary

Add an equiv method to the StabilizerState class, that checks if the generating sets of two stabilizer states generate the same stabilizer group.

close #9338

Details and comments

@ShellyGarion ShellyGarion added the mod: quantum info Related to the Quantum Info module (States & Operators) label Feb 7, 2023
@ShellyGarion ShellyGarion added this to the 0.24.0 milestone Feb 7, 2023
@ShellyGarion ShellyGarion requested review from a team and ikkoham as code owners February 7, 2023 12:41
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Feb 7, 2023

Pull Request Test Coverage Report for Build 4126554322

  • 13 of 19 (68.42%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 85.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/quantum_info/states/stabilizerstate.py 13 19 68.42%
Files with Coverage Reduction New Missed Lines %
src/vf2_layout.rs 1 86.44%
Totals Coverage Status
Change from base Build 4126551967: -0.002%
Covered Lines: 67238
Relevant Lines: 78851

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the maths off the top of my head, but assuming that's correct, the rest of this looks fairly straightforwards. I only had minor comments.

alexanderivrii
alexanderivrii previously approved these changes Feb 8, 2023
Copy link
Contributor

@alexanderivrii alexanderivrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Shelly! LGTM, though best to check to @jakelishman or @ikkoham to see if they have any further comments,

jakelishman
jakelishman previously approved these changes Feb 8, 2023
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shelly!

@jakelishman jakelishman added Changelog: New Feature Include in the "Added" section of the changelog automerge labels Feb 8, 2023
@ikkoham ikkoham removed the automerge label Feb 8, 2023
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late. LGTM, but I have some minor comments.

qiskit/quantum_info/states/stabilizerstate.py Outdated Show resolved Hide resolved
qiskit/quantum_info/states/stabilizerstate.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. LGTM!

@mergify mergify bot merged commit 8ec6749 into Qiskit:main Feb 8, 2023
pranay1990 pushed a commit to pranay1990/qiskit-terra that referenced this pull request Feb 9, 2023
* add equiv method to StabilizerState class

* add a test for equiv method

* add release notes

* add explanantion to the tests

* update comment in tests

* updates following review

* update exp_val calculation

* updates following review

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an equiv method to the StabilizerState class
6 participants