Fix bad deprecation of Register.name_format #9494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inadvertantly made the class attribute accessible only from instances. It's no use for this to only be on instances, since you historically needed to validate against the regex to be sure the instance initialisation would succeed.
jakelishman
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
The positive interaction between `classmethod` and `property` was apparently only added in Python 3.9.
Pull Request Test Coverage Report for Build 4056096435
💛 - Coveralls |
mtreinish
reviewed
Jan 31, 2023
releasenotes/notes/fix-register-name-format-deprecation-61ad5b06d618bb29.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/fix-register-name-format-deprecation-61ad5b06d618bb29.yaml
Show resolved
Hide resolved
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
approved these changes
Jan 31, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Fix bad deprecation of Register.name_format This inadvertantly made the class attribute accessible only from instances. It's no use for this to only be on instances, since you historically needed to validate against the regex to be sure the instance initialisation would succeed. * Use custom descriptor instead of classmethod/property The positive interaction between `classmethod` and `property` was apparently only added in Python 3.9. * Fixup release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 06f5ac1)
This was referenced Jan 31, 2023
mergify bot
added a commit
that referenced
this pull request
Jan 31, 2023
* Fix bad deprecation of Register.name_format This inadvertantly made the class attribute accessible only from instances. It's no use for this to only be on instances, since you historically needed to validate against the regex to be sure the instance initialisation would succeed. * Use custom descriptor instead of classmethod/property The positive interaction between `classmethod` and `property` was apparently only added in Python 3.9. * Fixup release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 06f5ac1) Co-authored-by: Jake Lishman <jake@binhbar.com>
pranay1990
pushed a commit
to pranay1990/qiskit-terra
that referenced
this pull request
Feb 9, 2023
* Fix bad deprecation of Register.name_format This inadvertantly made the class attribute accessible only from instances. It's no use for this to only be on instances, since you historically needed to validate against the regex to be sure the instance initialisation would succeed. * Use custom descriptor instead of classmethod/property The positive interaction between `classmethod` and `property` was apparently only added in Python 3.9. * Fixup release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This inadvertantly made the class attribute accessible only from instances. It's no use for this to only be on instances, since you historically needed to validate against the regex to be sure the instance initialisation would succeed.
Details and comments
Fix #9493