Fix TensoredOp.to_matrix with global coefficients
#9404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
Changelog: Bugfix
Cryoris
requested review from
a team,
manoelmarques,
woodsp-ibm and
ikkoham
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Cryoris
changed the title
TensoredOp.to_matrixTensoredOp.to_matrix with global coefficients
Cryoris
added
the
stable backport potential
jakelishman
reviewed
Jan 20, 2023
Pull Request Test Coverage Report for Build 3969315247
💛 - Coveralls |
jakelishman
approved these changes
Jan 20, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
* Fix TensoredOp.to_matrix * added reno * remove redundant size chec Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit dc8e232)
mergify bot
added a commit
that referenced
this pull request
Jan 20, 2023
* Fix TensoredOp.to_matrix * added reno * remove redundant size chec Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit dc8e232) Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9398.
Details and comments
As the author of #9398 correctly pointed out, this is the analogous error fixed in #9283, where the global coefficient was multiplied with the matrix once per element in the tensored expression, when it should only be applied once.