QGT is hermitian, not symmetric #9374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
a team,
manoelmarques,
woodsp-ibm and
ElePT
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
woodsp-ibm
added
Changelog: None
Pull Request Test Coverage Report for Build 3912843816
💛 - Coveralls |
|
This is separately fixed in #9085. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a minor bug where the complex part of the
LinCombQFIwas assumed to be symmetric, when it is actually hermitian.Details and comments
For a quantum state
\phi, the complex parts of the QFI is 4 times the following equationwhich is hermitian, i.e.
G_{ij} = conj(G_{ji}). TheLinCombQFIhowever implementedG_{ij} = G_{ji}which led to wrong results forderivative_types being any other thanDerivativeType.REAL.This does not include a reno since the QFIs are not yet released.