Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated MSBasisDecomposer transpiler pass #9342

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

mtreinish
Copy link
Member

Summary

This commit remove the deprecated MSBasisDecomposer transpiler pass. It was originally added as the first initial support in Qiskit for targeting ion trap backends and simply translated IBM's basis at the time (U3 and CX) to an Rx, Ry, and RXXgate basis. Since then the basis translator has completely supersceded this pass and nothing should be using it anymore (independent of the deprecation).

Details and comments

This commit remove the deprecated MSBasisDecomposer transpiler pass. It
was originally added as the first initial support in Qiskit for
targeting ion trap backends and simply translated IBM's basis at the
time (U3 and CX) to an Rx, Ry, and RXXgate basis. Since then the basis
translator has completely supersceded this pass and nothing should be
using it anymore (independent of the deprecation).
@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Jan 4, 2023
@mtreinish mtreinish added this to the 0.23.0 milestone Jan 4, 2023
@mtreinish mtreinish requested a review from a team as a code owner January 4, 2023 18:53
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Jan 4, 2023

Pull Request Test Coverage Report for Build 3874661697

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 84.583%

Totals Coverage Status
Change from base Build 3874629026: 0.004%
Covered Lines: 64086
Relevant Lines: 75767

💛 - Coveralls

@kdk kdk added the automerge label Jan 9, 2023
@mergify mergify bot merged commit f0f8638 into Qiskit:main Jan 9, 2023
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request Jan 11, 2023
This commit remove the deprecated MSBasisDecomposer transpiler pass. It
was originally added as the first initial support in Qiskit for
targeting ion trap backends and simply translated IBM's basis at the
time (U3 and CX) to an Rx, Ry, and RXXgate basis. Since then the basis
translator has completely supersceded this pass and nothing should be
using it anymore (independent of the deprecation).

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
This commit remove the deprecated MSBasisDecomposer transpiler pass. It
was originally added as the first initial support in Qiskit for
targeting ion trap backends and simply translated IBM's basis at the
time (U3 and CX) to an Rx, Ry, and RXXgate basis. Since then the basis
translator has completely supersceded this pass and nothing should be
using it anymore (independent of the deprecation).

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants