Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AQC returns a wrong circuit when the unitary has a determinant −1 #9331

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

EgrettaThula
Copy link
Contributor

Summary

Fixes #9327

Details and comments

Simply specifying dtype param of numpy.power() to be complex

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Dec 30, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 30, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@alexanderivrii
Copy link
Contributor

@EgrettaThula, thank you very much for the bug fix! It seems that you have a slight issue with formatting, a simple way to fix it is to run the command black qiskit test. Also can you please add releasenotes for this fix?

@ajavadia ajavadia added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jan 13, 2023
@ajavadia
Copy link
Member

thank you for finding this and fixing it too.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3914642425

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.853%

Totals Coverage Status
Change from base Build 3912955231: 0.0%
Covered Lines: 65751
Relevant Lines: 77488

💛 - Coveralls

@mergify mergify bot merged commit b4268b9 into Qiskit:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Approximate quantum compiler (AQC) returns a wrong circuit when the unitary has a determinant −1
6 participants