Fix ComposedOp.to_matrix
#9316
Merged
Fix ComposedOp.to_matrix
#9316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
added
stable backport potential
Cryoris
requested review from
a team,
manoelmarques,
woodsp-ibm and
ikkoham
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3875649126
💛 - Coveralls |
woodsp-ibm
approved these changes
Dec 21, 2022
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
Jan 11, 2023
* Fix ComposedOp.to_matrix * lint Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 12, 2023
* Fix ComposedOp.to_matrix * lint Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9283.
Details and comments
The
to_matrixmethod previously applied the global coefficient to each element in theComposedOp-- which it shouldn't have as the combo function is multiplicative. Also, the dot-product should be taken of individual numpy arrays, not of one massive numpy array with all operators inside, which fixed the Matrix-Vector product bug.