Fix primitives metadata #9285
Merged
Fix primitives metadata #9285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Julian Schuhmacher <jsc@zurich.ibm.com>
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3742930238
💛 - Coveralls |
|
LGTM! I would agree that this is straightforward enough to merge without a dedicated test, but let's hold merging off for a bit in case there are concerns. |
woodsp-ibm
added
Changelog: Bugfix
ElePT
commented
Dec 19, 2022
releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml
Outdated
Show resolved
Hide resolved
ikkoham
reviewed
Dec 19, 2022
releasenotes/notes/fix-primitives-metadata-1e79604126e26b53.yaml
Outdated
Show resolved
Hide resolved
Cryoris
approved these changes
Dec 20, 2022
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 12, 2023
* Fix bug metadata Co-authored-by: Julian Schuhmacher <jsc@zurich.ibm.com> * Add reno * Re-trigger CI * Fix typo Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com> Co-authored-by: Julian Schuhmacher <jsc@zurich.ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jschuhmac developed a custom estimator for his research project where additional metadata is saved, and realized that all values were updated with each iteration because the list of dicts was instantiated by reference. This PR fixes the reference
SamplerandEstimatorclasses to avoid this problem.Details and comments
Given that the only metadata currently saved are
shots, and they don't change between circuits, it is not possible to add a unit test with this implementation, but I think this fix is good to have in case anyone wants to extend these classes and save different metadata.