Fix add_calibration bug

[nkanazawa1989]

Summary

This quantum circuit fails in transpile with main.

from qiskit import pulse, circuit, transpile

# Parameterized calibration
param = circuit.Parameter("P1")
with pulse.build() as my_pulse:
    pulse.play(pulse.Constant(128, param), pulse.DriveChannel(0))

# Add calibration to the inst_map, to attach it through the transpile
inst_map = pulse.InstructionScheduleMap()
inst_map.add("my_gate", (0,), my_pulse)

# This is gate to transpile (to add calibration)
gate = circuit.Gate("my_gate", 1, params=[param])

# Some quantum circuit
qc = circuit.QuantumCircuit(1)
qc.append(gate, [0])

# Transpile to add calibration
qc_transpiled = transpile(qc, basis_gates=["my_gate"], inst_map=inst_map)

This PR fixes the bug.

Details and comments

During the transpile input QuantumCircuit is converted into DAGCircuit and the pulse gate calibration is ported from the provided inst_map. However, QuantumCircuit.add_calibration and DAGCircuit.add_calibration have different parameter formatting mechanism, and parameterized gate operand cannot be properly passed to the DAGCircuit calibration.

This PR updates both add_calibration method so that both methods identically format operand values.

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core
• @nkanazawa1989

[coveralls]

Pull Request Test Coverage Report for Build 3986668008

• 31 of 32 (96.88%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.005%) to 84.929%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/dagcircuit/dagcircuit.py	15	16	93.75%

Totals
Change from base Build 3986142857:	0.005%
Covered Lines:	66734
Relevant Lines:	78576

---

💛 - Coveralls

[mtreinish]

Lgtm, this makes sense to unify the param processing. Even if as pointed out in the comments the current mechanism is potentially fragile