Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8992 (SparsePauliOp.dot with real coefficients) #8998

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Oct 26, 2022

Summary

Fix SparsePauliOp.dot between operators with real coefficients.
To fix this, the dtype that SparsePauliOp can take is restricted to
np.complex128 and object.

Fix #8992

Details and comments

@ikkoham ikkoham requested a review from a team as a code owner October 26, 2022 00:55
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@ikkoham ikkoham added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) stable backport potential The bug might be minimal and/or import enough to be port to stable labels Oct 26, 2022
@ikkoham ikkoham added this to the 0.22.1 milestone Oct 26, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3325384445

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 84.404%

Totals Coverage Status
Change from base Build 3324535595: 0.03%
Covered Lines: 61734
Relevant Lines: 73141

💛 - Coveralls

@mergify mergify bot merged commit be1e697 into Qiskit:main Oct 26, 2022
mergify bot pushed a commit that referenced this pull request Oct 26, 2022
(cherry picked from commit be1e697)
mergify bot added a commit that referenced this pull request Oct 26, 2022
(cherry picked from commit be1e697)

Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
@ikkoham ikkoham deleted the qinfo/sparse-pauli-op-real branch October 26, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SparsePauliOp casting of coeffs causes errors for dtype=real
4 participants