Remove verify_parallel_map script #8962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
added
on hold
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
force-pushed
the
remove-parallel-verify-script
branch
from
6788250
to
0834b47
Compare
Pull Request Test Coverage Report for Build 3372572751
💛 - Coveralls |
In Qiskit#7658 we disabled multiprocessing as part of unittest runs in CI because the multiple layers of parallelism (subprocess from stestr, multiprocessing from qiskit, and multithreading from rust in qiskit) were triggering a latent bug in python's multiprocessing implementation that was blocking CI. To counter the lost coverage from disabling multiprocessing in that PR we added a script verify_parallel_map which force enabled multiprocessing and validated transpile() run in parallel executed correctly. However, in Qiskit#8952 we introduced a model for selectively enabling multiprocessing just for a single test method. This should allow us to avoid the stochastic failure triggering the deadlock in python's multiprocessing by overloading parallelism but still test in isolation that parallel_map() works. This commit builds on the test class introduced in Qiskit#8952 and adds identical test cases to what was previously in verify_parallel_map.py to move that coverage into the unit test suite. Then the verify_parallel_map script is removed and all callers are updated to just run unit tests instead of also executing that script.
mtreinish
force-pushed
the
remove-parallel-verify-script
branch
from
0834b47
to
3067250
Compare
|
Now that #8952 has merged, I've rebased this and it should be ready for review now. |
jakelishman
approved these changes
Nov 1, 2022
Comment on lines
+1841
to
+1843
| for count in counts: | ||
| self.assertTrue(math.isclose(count["0000000000000000"], 500, rel_tol=0.1)) | ||
| self.assertTrue(math.isclose(count["0111111111111111"], 500, rel_tol=0.1)) |
There was a problem hiding this comment.
For completely random seeding, this would have about a 1/640 failure chance, which would be way too high. It's fine given that we've fixed the seed, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #7658 we disabled multiprocessing as part of unittest runs in CI
because the multiple layers of parallelism (subprocess from stestr,
multiprocessing from qiskit, and multithreading from rust in qiskit)
were triggering a latent bug in python's multiprocessing implementation
that was blocking CI. To counter the lost coverage from disabling
multiprocessing in that PR we added a script verify_parallel_map which
force enabled multiprocessing and validated transpile() run in parallel
executed correctly. However, in #8952 we introduced a model for
selectively enabling multiprocessing just for a single test method. This
should allow us to avoid the stochastic failure triggering the deadlock
in python's multiprocessing by overloading parallelism but still test in
isolation that parallel_map() works.
This commit builds on the test class introduced in #8952 and adds
identical test cases to what was previously in verify_parallel_map.py to
move that coverage into the unit test suite. Then the
verify_parallel_map script is removed and all callers are updated to
just run unit tests instead of also executing that script.
Details and comments
This PR is based on top of #8952, I've marked this as on hold until #8952 mergesand this PR branch is rebased.