Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pauli_basis deprecation #8905

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

chriseclectic
Copy link
Member

Summary

Fixes the removal of pauli_list kwarg of pauli_basis which broke existing code using the pauli_list=True future compatibility on upgrade to Qiskit Terra 0.22. This kwarg has been added back to the the function with a deprecation warning instead.

Details and comments

@chriseclectic chriseclectic added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: Deprecation Include in "Deprecated" section of changelog Changelog: Bugfix Include in the "Fixed" section of the changelog labels Oct 14, 2022
@chriseclectic chriseclectic added this to the 0.22.1 milestone Oct 14, 2022
@chriseclectic chriseclectic requested review from a team and ikkoham as code owners October 14, 2022 13:52
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this. The options shouldn't have been removed without deprecation even though it doesn't do anything after the change of the default format.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3250465537

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.753%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/quantum_info/operators/symplectic/pauli_utils.py 3 4 75.0%
Totals Coverage Status
Change from base Build 3249813481: 0.002%
Covered Lines: 61905
Relevant Lines: 73042

💛 - Coveralls

@mergify mergify bot merged commit 8ccfda5 into Qiskit:main Oct 14, 2022
mergify bot pushed a commit that referenced this pull request Oct 14, 2022
(cherry picked from commit 8ccfda5)
mergify bot added a commit that referenced this pull request Oct 14, 2022
(cherry picked from commit 8ccfda5)

Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
@ikkoham
Copy link
Contributor

ikkoham commented Oct 15, 2022

Thank you. My bad.

#8510
I had set the original PR to DeprecationWarning at first, but I removed it in the middle of the PR. Surely we can't delete it without DeprecationWarning. This is my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Changelog: Deprecation Include in "Deprecated" section of changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants