Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note that chop is not supported by SparsePauliOp either #8895

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

kevinsung
Copy link
Contributor

Summary

See title.

Details and comments

We could actually modify chop to check for Parameters and ignore them, but that would incur some overhead. @ikkoham

@kevinsung kevinsung requested review from a team and ikkoham as code owners October 13, 2022 15:27
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Oct 13, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@jakelishman jakelishman removed the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Oct 13, 2022
@coveralls
Copy link

coveralls commented Oct 13, 2022

Pull Request Test Coverage Report for Build 3254928391

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.75%

Totals Coverage Status
Change from base Build 3250961897: 0.0%
Covered Lines: 61903
Relevant Lines: 73042

💛 - Coveralls

@mtreinish mtreinish added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Oct 13, 2022
@mtreinish mtreinish added this to the 0.22.1 milestone Oct 13, 2022
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I didn't notice that. LGTM

@ikkoham ikkoham added the mod: quantum info Related to the Quantum Info module (States & Operators) label Oct 15, 2022
@mergify mergify bot merged commit c950549 into Qiskit:main Oct 15, 2022
mergify bot pushed a commit that referenced this pull request Oct 15, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit c950549)
mergify bot added a commit that referenced this pull request Oct 15, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit c950549)

Co-authored-by: Kevin J. Sung <kevjsung@umich.edu>
@kevinsung kevinsung deleted the sparse-pauli-doc branch October 15, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation mod: quantum info Related to the Quantum Info module (States & Operators) stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants