Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shots to QuasiDistributions in primitives.Sampler #8791

Merged

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Sep 26, 2022

Summary

QuasiDistribution can have shots. This has been forgotten in previous implementations, but is important because the some algorithms use it.

This is the followup PR of #8137 (not released yet).

Part of #8754.

Details and comments

@ikkoham ikkoham added Changelog: None Do not include in changelog mod: primitives Related to the Primitives module labels Sep 26, 2022
@ikkoham ikkoham requested review from a team and t-imamichi as code owners September 26, 2022 05:57
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Sep 26, 2022

Pull Request Test Coverage Report for Build 3201920744

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 84.739%

Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
Totals Coverage Status
Change from base Build 3201920356: 0%
Covered Lines: 61840
Relevant Lines: 72977

💛 - Coveralls

@mergify mergify bot merged commit 3936c43 into Qiskit:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog mod: primitives Related to the Primitives module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants