Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TwoQubitWeylDecomposition pickle-able #7333
Make TwoQubitWeylDecomposition pickle-able #7333
Changes from 1 commit
9fd0ff9
af2cecc
2027765
332f7d3
ebab460
5c2507b
f688f87
b462a32
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may also be worth adding a very similar test that
copy.deepcopy
andcopy.copy
work correctly as well/deepcopy
presumably will because it's a full pickle/unpickle by default, butcopy
might do something funny; I think it basically calls__getstate__
, then restores it with an immediate call to__setstate__
without recursing the pickle through the state. I would guess it does the right thing and calls__getnewargs_ex__
if defined, but I don't really know, and it might be worth a test, since Qiskit uses thecopy
module pretty extensively.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned recently that
f"{repr(x)}"
can also be written asf"{x!r}"
(and!s
forstr
), which seems like a fun way to introduce a million more sigils to the strings and make them completely unreadable. When we get to Python 3.8+ only, there's an even more arcane one:f"{weyl1=}"
, which is equivalent tof"weyl1={weyl1!r}"
.