Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stdgates.inc from arXiv:2104.14722 #6492

Closed
wants to merge 1 commit into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Jun 1, 2021

Adding stdgates.inc from https://arxiv.org/abs/2104.14722

@1ucian0 1ucian0 requested a review from a team as a code owner June 1, 2021 13:29
@1ucian0 1ucian0 added this to the 0.18 milestone Jun 8, 2021
@ajavadia
Copy link
Member

ajavadia commented Jun 8, 2021

Looks correct, but I think we should add this to the openqasm repository and then make qiskit dependent on that package. Also move parser there and just consume the AST here. What do you think?

@1ucian0
Copy link
Member Author

1ucian0 commented Jun 13, 2021

Looks correct, but I think we should add this to the openqasm repository and then make qiskit dependent on that package. Also move parser there and just consume the AST here. What do you think?

I like the idea of having an independent package for openqasm. However, if we are talking about https://github.com/Qiskit/openqasm/ , that is not a package to depend upon. Are you talking about a different repo? If not, is there any plan to have an openqasm package? If yes, shall we wait for it or can we merge this one in the meanwhile?

@kdk kdk modified the milestones: 0.18, 0.19 Jul 6, 2021
@kdk kdk mentioned this pull request Jul 15, 2021
3 tasks
@jakelishman
Copy link
Member

Given that I've been thinking about/making editor plugins and a language server for QASM 2/3, I'm also +1 on having the QASM lexer/parser be a separate package that qiskit depends on. It'd let make a langauge server for it without reinventing the wheel or having the huge dependency on terra.

@1ucian0
Copy link
Member Author

1ucian0 commented Nov 1, 2021

This PR was superseded by #6565. Closing.

@1ucian0 1ucian0 closed this Nov 1, 2021
@1ucian0 1ucian0 deleted the stdgates.inc branch November 1, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants