fix for #111 #151
Merged
fix for #111 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atilag
reviewed
Nov 17, 2017
test/python/qasm/issue_111.qasm
Outdated
| @@ -0,0 +1,18 @@ | |||
| OPENQASM 2.0; | |||
There was a problem hiding this comment.
Can we rename this file to have a more descriptive name? Something like: test_float_precision.qasm
test/python/qasm/issue_81.qasm
Outdated
| @@ -0,0 +1,22 @@ | |||
| OPENQASM 2.0; | |||
There was a problem hiding this comment.
Same here - more descriptive name.
test/python/test_mapper.py
Outdated
| def tearDown(self): | ||
| pass | ||
|
|
||
| def test_issue_81(self): |
There was a problem hiding this comment.
Along the same line of previous comments, I think we should have a better descriptive method name here.
test/python/test_mapper.py
Outdated
| count2 = result2.get_counts("test") | ||
| self.assertEqual(count1.keys(), count2.keys(),) | ||
|
|
||
| def test_issue_111(self): |
added 2 commits
November 17, 2017 11:50
taalexander
pushed a commit
to taalexander/qiskit-terra
that referenced
this pull request
May 2, 2019
* added measurement calibration doc * Update measurement_calibration.rst fixed numerical typo in matrix * apdated the doc for measurement calibration * added RB documentation * fix lint erros * fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathwithsympy. Fully removingmathis a bit more complicated, so I will do it in a following PR.