Add some more gates to CollectCliffords pass #13214
Open
+115
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Samantha Barron <samantha.v.barron@ibm.com>
ShellyGarion
added
Changelog: New Feature
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11013369525Details
💛 - Coveralls |
ShellyGarion
changed the title
Comment on lines
6
to
7
| can collect :class:`.RZGate(np.pi/2)` gates and other unitary gates that are :class:`.Clifford()`gates | ||
| for certain parameters. |
There was a problem hiding this comment.
Suggested change
| can collect :class:`.RZGate(np.pi/2)` gates and other unitary gates that are :class:`.Clifford()`gates | |
| for certain parameters. | |
| can collect :class:`.RZGate(np.pi/2)` gates and other unitary gates that are :class:`.Clifford()` gates | |
| for certain parameters. |
Note the extra space before "gates" -- I believe this is what's responsible for CI failures :).
There was a problem hiding this comment.
good catch!
The CI failure is not related. it's due to QPY backwards tests. should be fixed after #13202 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #13138
Add an argument
matrix_basedto theCollectCliffordstranspiler pass.If the new parameter
matrix_based=True, theCollectCliffordstranspiler pass can collectRz(pi/2)gates and other unitary gates that are Clifford gates for certain parameters.Details and comments
The PR is based on the suggestion of @samanthavbarron in #13138 and discussions with @alexanderivrii