Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header to qpy file for footnotes #13200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Eric-Arellano
Copy link
Collaborator

Qiskit/documentation#1987 adds proper support for footnotes to the docs. The docs will render much more clearly if we have an h2 to delineate where the footnotes start.

@Eric-Arellano Eric-Arellano requested a review from a team as a code owner September 20, 2024 13:38
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

qiskit/qpy/__init__.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 10995274058

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 88.802%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 2 93.23%
Totals Coverage Status
Change from base Build 10960010824: 0.003%
Covered Lines: 73496
Relevant Lines: 82764

💛 - Coveralls

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. #13202 should fix the QPY backwards compatibility test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants